Project

General

Profile

Bug #24817

gtest_parallel is not py3-ready and Ceph's use of it introduces undeclared indirect dependency on Python 2

Added by Nathan Cutler 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
07/06/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

When I run "make check" on a py3-only system, I get the following failures in the three unit tests that are run using gtest-parallel:

on py3-only I'm seeing:

 58/154 Test  #61: unittest_throttle .......................***Failed    0.20 sec
/usr/bin/env: 'python2': No such file or directory
...
 90/154 Test  #93: unittest_crush ..........................***Failed    0.20 sec
/usr/bin/env: 'python2': No such file or directory
...
105/154 Test #108: unittest_erasure_code_shec_all ..........***Failed    0.20 sec
/usr/bin/env: 'python2': No such file or directory
...

These three tests were migrated to gtest-parallel by https://github.com/ceph/ceph/commit/13bc625b5f06f91031127eccb0c94e0a71c24374 (that commit actually migrated four unit tests to gtest-parallel, but was partially reverted by 814a4a2388f029741bc84bf53bda136f49ea0ddd).

The gtest-parallel script that is generating the error, then, is https://github.com/google/gtest-parallel/blob/master/gtest-parallel - i.e., not even part of the Ceph codebase.

Until gtest-parallel has been fixed to work with Python 3, I don't think we can use it. Also, when and if we do use it, I would argue that it should be packaged first and the build dependency declared in the RPM spec/Debian control files.

History

#1 Updated by Nathan Cutler 10 months ago

  • Status changed from New to Need Review

#2 Updated by Nathan Cutler 10 months ago

  • Subject changed from gtest_parallel is not py3-ready to gtest_parallel is not py3-ready and Ceph's use of it introduces undeclared indirect dependency on Python 2

#3 Updated by Nathan Cutler 10 months ago

  • Description updated (diff)

#4 Updated by Nathan Cutler 9 months ago

  • Status changed from Need Review to Resolved
  • Assignee changed from Nathan Cutler to Kefu Chai

Also available in: Atom PDF