Project

General

Profile

Actions
Copy link

Bug #24710

closed

make check integration needs mktemp and should clean up after itself

Added by Douglas Fuller almost 6 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Sebastian Wagner
Category:
testing
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

In commit d7ead639dcd606fcf1b245061cccb8e655d5274e, make check sets up $CEPH_BUILD_VIRTUALENV/mgr-dashboard-v2-virtualenv . $CEPH_BUILD_VIRTUALENV defaults to /tmp, so only one user on a given machine may run 'make check'. Additionally, it does not appear to clean up these directories afterward.

This directory name should be randomized and then removed afterward.

Actions
Copy link
 #1

Updated by Douglas Fuller almost 6 years ago

  • Assignee set to Sebastian Wagner
Actions
Copy link
 #2

Updated by Sebastian Wagner almost 6 years ago

Moving all virtualenvs into /tmp was introduced in 1342ea80d56a06756cd7099a4f495b4c53dedd71 (In PR https://github.com/ceph/ceph/pull/8822 ). I'm not feeling that qualified change things here. Maybe Casey Bodley or Ali Maredia can help here?

Actions
Copy link
 #3

Updated by Kefu Chai almost 6 years ago

we do respect $TMPDIR, and run-make-check.sh does remove the created venv, 

    if run "$@" ; then
        rm -fr ${CEPH_BUILD_VIRTUALENV:-/tmp}/*virtualenv*
        echo "cmake check: successful run on $(git rev-parse HEAD)" 
        return 0
    else

but probably we should put the venv into build directory instead.

Actions
Copy link
 #4

Updated by Sebastian Wagner about 5 years ago

  • Status changed from New to Closed

environments are no longer located in /tmp

Actions
Copy link

Also available in: Atom PDF