Project

General

Profile

Bug #24685

config options: possible inconsistency between flag 'can_update_at_runtime' and 'flags' list

Added by Tatjana Dehler almost 6 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Monitor
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I'm wondering if there is a inconsistency between the 'can_update_at_runtime' flag and the 'flags' list for the config options.

E.g. 'ceph config help bluestore_compression_required_ratio --format=json-pretty' returns:

{
    "name": "bluestore_compression_required_ratio",
    "type": "double",
    "level": "advanced",
    "desc": "Compression ratio required to store compressed data",
    "long_desc": "If we compress data and get less than this we discard the result and store the original uncompressed data.",
    "default": 0.875000,
    "daemon_default": "",
    "tags": [],
    "services": [],
    "see_also": [],
    "min": "",
    "max": "",
    "can_update_at_runtime": true,
    "flags": [
        "runtime" 
    ]
}

Which is correct from my point of view. But 'ceph config help bluestore_compression_required_ratio --format=json-pretty' returns:

{
    "name": "bluestore_cache_trim_max_skip_pinned",
    "type": "uint64_t",
    "level": "dev",
    "desc": "Max pinned cache entries we consider before giving up",
    "long_desc": "",
    "default": 64,
    "daemon_default": "",
    "tags": [],
    "services": [],
    "see_also": [],
    "min": "",
    "max": "",
    "can_update_at_runtime": true,
    "flags": []
}

As you can see 'can_update_at_runtime' is 'true' but 'runtime' is missing in the 'flags' list.

History

#1 Updated by Patrick Donnelly over 5 years ago

  • Project changed from Ceph to RADOS
  • Category deleted (common)
  • Component(RADOS) Monitor added

#2 Updated by Tatjana Dehler about 5 years ago

I retested it and the issue is gone from my point of view. Unfortunately I can't tell which pull request fixed it.

Could someone please resolve the issue for me (as I don't have the permissions to do it myself)? - Thanks.

#3 Updated by Nathan Cutler about 5 years ago

  • Status changed from New to Resolved

#4 Updated by Nathan Cutler about 5 years ago

@Tatjana - I added you to the "ceph developers" group so you should be able to change Status etc. fields.

#5 Updated by Tatjana Dehler about 5 years ago

Yes, I can edit them now. Thanks Nathan :)

Also available in: Atom PDF