Project

General

Profile

Feature #24651

mgr/dashboard: Improve SSL certificate import to no longer require a Mgr restart

Added by Lenz Grimmer 6 months ago. Updated 25 days ago.

Status:
New
Priority:
Normal
Category:
dashboard/general
Target version:
Start date:
06/25/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Now that https://github.com/ceph/ceph/pull/22634 has been merged into master, the process for importing SSL certificates into the dashboard module commands should be improved to no longer require restarting the Ceph Manager. According to John Spray, we need to "implement new commands in the dashboard module to accept the certificate input, and then in the handle_command function consume the inbuf field."


Related issues

Related to mgr - Bug #24648: 'ceph mgr enable/disable <module>' interrupts all other modules New 06/25/2018

History

#1 Updated by Dan Mick 6 months ago

Here's an unmerged example, called directly from handle_command():

    def do_post(self, cmd, inbuf):
        try:
            metadata = Module.validate_crash_metadata(inbuf)
        except Exception as e:
            return errno.EINVAL, '', 'malformed crash metadata: %s' % e

        crashid = metadata['crash_id']
        key = 'crash/%s' % crashid
        if self.get_store(key):
            return errno.EADDRINUSE, '', 'crash id %s already saved' % crashid

        self.set_store(key, inbuf)
        return 0, '', 'Posted %s' % crashid

#2 Updated by Sebastian Wagner 6 months ago

  • Assignee changed from Lenz Grimmer to Sebastian Wagner

#3 Updated by Sebastian Wagner 6 months ago

  • Status changed from New to In Progress

#4 Updated by Sebastian Wagner 5 months ago

After investigating a bit:

  1. Reloading just the CherryPy engine is not implemented.
  2. enabling or disabling any module from within a module is not possible.

Maybe it's possible to run execv ourselves?

#6 Updated by Sebastian Wagner 2 months ago

  • Related to Bug #24648: 'ceph mgr enable/disable <module>' interrupts all other modules added

#7 Updated by Lenz Grimmer 25 days ago

  • Status changed from In Progress to New
  • Pull request ID set to 23447

This is currently on hold - the pending PR was closed due to lack of activity.

Also available in: Atom PDF