Project

General

Profile

Actions
Copy link

Feature #24651

closed

mgr/dashboard: Improve SSL certificate import to no longer require a Mgr restart

Added by Lenz Grimmer almost 6 years ago. Updated about 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Sebastian Wagner
Category:
General
Target version:
Ceph - v14.0.0
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
23447

Description

Now that https://github.com/ceph/ceph/pull/22634 has been merged into master, the process for importing SSL certificates into the dashboard module commands should be improved to no longer require restarting the Ceph Manager. According to John Spray, we need to "implement new commands in the dashboard module to accept the certificate input, and then in the handle_command function consume the inbuf field."

Related issues 1 (1 open — 0 closed)

Related to mgr - Bug #24648: 'ceph mgr enable/disable <module>' interrupts all other modulesNew

Actions
Actions
Copy link
 #1

Updated by Dan Mick almost 6 years ago

Here's an unmerged example, called directly from handle_command():

    def do_post(self, cmd, inbuf):
        try:
            metadata = Module.validate_crash_metadata(inbuf)
        except Exception as e:
            return errno.EINVAL, '', 'malformed crash metadata: %s' % e

        crashid = metadata['crash_id']
        key = 'crash/%s' % crashid
        if self.get_store(key):
            return errno.EADDRINUSE, '', 'crash id %s already saved' % crashid

        self.set_store(key, inbuf)
        return 0, '', 'Posted %s' % crashid
Actions
Copy link
 #2

Updated by Sebastian Wagner almost 6 years ago

  • Assignee changed from Lenz Grimmer to Sebastian Wagner
Actions
Copy link
 #3

Updated by Sebastian Wagner almost 6 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by Sebastian Wagner over 5 years ago

After investigating a bit:

  1. Reloading just the CherryPy engine is not implemented.
  2. enabling or disabling any module from within a module is not possible.

Maybe it's possible to run execv ourselves?

Actions
Copy link
 #5

Updated by Ricardo Marques over 5 years ago

Actions
Copy link
 #6

Updated by Sebastian Wagner over 5 years ago

  • Related to Bug #24648: 'ceph mgr enable/disable <module>' interrupts all other modules added
Actions
Copy link
 #7

Updated by Lenz Grimmer over 5 years ago

  • Status changed from In Progress to New
  • Pull request ID set to 23447

This is currently on hold - the pending PR was closed due to lack of activity.

Actions
Copy link
 #8

Updated by Sebastian Wagner over 4 years ago

  • Status changed from New to Rejected

We cannot (And will likely never be able to) properly restart modules, therefore let's close this issue as rejected. Relates to https://github.com/ceph/ceph/pull/32051

Actions
Copy link
 #9

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General
Actions
Copy link

Also available in: Atom PDF