Project

General

Profile

Actions

Bug #24533

closed

PurgeQueue sometimes ignores Journaler errors

Added by John Spray almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
jewel,luminous,mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We check journaler.get_error() in PurgeQueue::_recover, but never later in _consume -- if something like a decode error happens, the MDS may silently stop progressing the queue.

Ticket inspired by thread "[ceph-users] MDS: journaler.pq decode error"


Related issues 3 (0 open3 closed)

Copied to CephFS - Backport #24694: luminous: PurgeQueue sometimes ignores Journaler errorsResolvedNathan CutlerActions
Copied to CephFS - Backport #24695: jewel: PurgeQueue sometimes ignores Journaler errorsRejectedActions
Copied to CephFS - Backport #24703: mimic: PurgeQueue sometimes ignores Journaler errorsResolvedNathan CutlerActions
Actions #1

Updated by John Spray almost 6 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Patrick Donnelly almost 6 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Assignee set to John Spray
  • Target version set to v14.0.0
  • Source set to Development
  • Backport set to jewel,luminous,mimic
  • Component(FS) MDS added
Actions #3

Updated by Patrick Donnelly almost 6 years ago

  • Copied to Backport #24694: luminous: PurgeQueue sometimes ignores Journaler errors added
Actions #4

Updated by Patrick Donnelly almost 6 years ago

  • Copied to Backport #24695: jewel: PurgeQueue sometimes ignores Journaler errors added
Actions #5

Updated by Patrick Donnelly almost 6 years ago

  • Copied to Backport #24703: mimic: PurgeQueue sometimes ignores Journaler errors added
Actions #6

Updated by Nathan Cutler over 5 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF