Project

General

Profile

Bug #24456

caught exceptions are not being logged

Added by Alfredo Deza about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
06/08/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

There are a couple of places where this pattern is used:

        try:
            self.prepare(args)
        except Exception:
            logger.error('lvm prepare was unable to complete')
            logger.info('will rollback OSD ID creation')
            rollback_osd(args, self.osd_id)
            raise

In some cases, an exception can be thrown in rollback_osd, so the original exception is lost. This needs to be logged with `logger.exception`

History

#1 Updated by Andrew Schoen about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Andrew Schoen

#2 Updated by Andrew Schoen about 1 year ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF