Project

General

Profile

Bug #24348

rgw (luminous) making implicit_tenants backwards compatible.

Added by Marcus Watts 10 months ago. Updated 10 months ago.

Status:
Need Review
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
05/30/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
mimic, luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

In jewel, "rgw keystone implicit tenants" only applied to swift. In luminous(,+), it applies to s3 also. Sites that used this feature with jewel now have outstanding data that depends on the old behavior. One proposal to fix this was to expand this option so that it can be set to "none", "all", "s3" or "swift".


Related issues

Copied to rgw - Backport #24393: luminous: rgw: making implicit_tenants backwards compatible Resolved

History

#1 Updated by Marcus Watts 10 months ago

I've made a PR that I beleive will address this.
https://github.com/ceph/ceph/pull/22363
this is for luminous: I'll need to make what should be a very similar PR for master.

The main complication is that it turns out the code that was in luminous only looked at "rgw keystone implicit tenants" when creating a new shadow user. With this PR, it look at that first to see if it's operating in "split mode" (implicit tenants only enabled for one protocol), and if so, only looks for the kind of shadow user that it would otherwise create.

#2 Updated by Matt Benjamin 10 months ago

  • Status changed from New to Need Review

#3 Updated by Nathan Cutler 10 months ago

  • Backport set to mimic, luminous

#4 Updated by Marcus Watts 10 months ago

I've made a PR against master.
https://github.com/ceph/ceph/pull/22378
exactly the same logic as the original PR I made against luminous. This should apply cleanly against mimic as well.

#5 Updated by Nathan Cutler 10 months ago

  • Copied to Backport #24393: luminous: rgw: making implicit_tenants backwards compatible added

Also available in: Atom PDF