Bug #24346: objects in cache never refresh after rgw_cache_expiry_interval - rgw - Ceph

Actions

Copy link

Bug #24346

closed

objects in cache never refresh after rgw_cache_expiry_interval

Added by Casey Bodley almost 6 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Target version:

% Done:

Source:

Tags:

Backport:

luminous mimic jewel

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

ObjectCacheInfo::time_added is only initialized on first insert. so once an entry reaches its rgw_cache_expiry_interval, it can't be refreshed until the lru removes its entry entirely

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Matt Benjamin almost 6 years ago

I'm unclear why there is any trace of already-expired items. I guess the intrusive cache change doesn't have this issue?

Actions

Copy link

Updated by Casey Bodley almost 6 years ago

Status changed from 12 to Fix Under Review

https://github.com/ceph/ceph/pull/22324

Actions

Copy link

Updated by Casey Bodley almost 6 years ago

Matt Benjamin wrote:

I'm unclear why there is any trace of already-expired items. I guess the intrusive cache change doesn't have this issue?

ObjectCache::get() only takes a read lock, so does not remove these expired items from the map. the lru will remove them eventually

Actions

Copy link

Updated by Matt Benjamin almost 6 years ago

Status changed from Fix Under Review to Pending Backport
Backport changed from luminous mimic to luminous mimic jewel

jewel added to backports list as the cache expiration change is present

Actions

Copy link

Updated by Pavan Rallabhandi almost 6 years ago

It would be great if this can make it to Jewel 10.2.11, thanks!

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

Copied to Backport #24384: luminous: objects in cache never refresh after rgw_cache_expiry_interval added

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

Copied to Backport #24385: mimic: objects in cache never refresh after rgw_cache_expiry_interval added

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

Copied to Backport #24386: jewel: rgw: objects in cache never refresh after rgw_cache_expiry_interval added

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

Pavan Rallabhandi wrote:

It would be great if this can make it to Jewel 10.2.11, thanks!

Do you want to take #24386 then? If you stage the backport quickly, it might make it in.

Actions

Copy link

#10

Updated by Pavan Rallabhandi almost 6 years ago

Nathan Cutler wrote:

Pavan Rallabhandi wrote:

It would be great if this can make it to Jewel 10.2.11, thanks!

Do you want to take #24386 then? If you stage the backport quickly, it might make it in.

Sorry Nathan, somehow missed this update. Have raised a backport PR for Jewel now, hope this is still in time.

Actions

Copy link

#11