Project

General

Profile

Bug #24346

objects in cache never refresh after rgw_cache_expiry_interval

Added by Casey Bodley 6 months ago. Updated 6 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
05/30/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous mimic jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

ObjectCacheInfo::time_added is only initialized on first insert. so once an entry reaches its rgw_cache_expiry_interval, it can't be refreshed until the lru removes its entry entirely


Related issues

Copied to rgw - Backport #24384: luminous: objects in cache never refresh after rgw_cache_expiry_interval Resolved
Copied to rgw - Backport #24385: mimic: objects in cache never refresh after rgw_cache_expiry_interval Resolved
Copied to rgw - Backport #24386: jewel: rgw: objects in cache never refresh after rgw_cache_expiry_interval In Progress

History

#1 Updated by Matt Benjamin 6 months ago

I'm unclear why there is any trace of already-expired items. I guess the intrusive cache change doesn't have this issue?

#2 Updated by Casey Bodley 6 months ago

  • Status changed from Verified to Need Review

#3 Updated by Casey Bodley 6 months ago

Matt Benjamin wrote:

I'm unclear why there is any trace of already-expired items. I guess the intrusive cache change doesn't have this issue?

ObjectCache::get() only takes a read lock, so does not remove these expired items from the map. the lru will remove them eventually

#4 Updated by Matt Benjamin 6 months ago

  • Status changed from Need Review to Pending Backport
  • Backport changed from luminous mimic to luminous mimic jewel

jewel added to backports list as the cache expiration change is present

#5 Updated by Pavan Rallabhandi 6 months ago

It would be great if this can make it to Jewel 10.2.11, thanks!

#6 Updated by Nathan Cutler 6 months ago

  • Copied to Backport #24384: luminous: objects in cache never refresh after rgw_cache_expiry_interval added

#7 Updated by Nathan Cutler 6 months ago

  • Copied to Backport #24385: mimic: objects in cache never refresh after rgw_cache_expiry_interval added

#8 Updated by Nathan Cutler 6 months ago

  • Copied to Backport #24386: jewel: rgw: objects in cache never refresh after rgw_cache_expiry_interval added

#9 Updated by Nathan Cutler 6 months ago

Pavan Rallabhandi wrote:

It would be great if this can make it to Jewel 10.2.11, thanks!

Do you want to take #24386 then? If you stage the backport quickly, it might make it in.

#10 Updated by Pavan Rallabhandi 6 months ago

Nathan Cutler wrote:

Pavan Rallabhandi wrote:

It would be great if this can make it to Jewel 10.2.11, thanks!

Do you want to take #24386 then? If you stage the backport quickly, it might make it in.

Sorry Nathan, somehow missed this update. Have raised a backport PR for Jewel now, hope this is still in time.

#11 Updated by Matt Benjamin 6 months ago

I have already created (last week):
https://github.com/ceph/ceph/pull/22377 (jewel)
https://github.com/ceph/ceph/pull/22369 (luminou)

Also available in: Atom PDF