Feature #24065
closed[fast-diff] interlock object-map/fast-diff features together
0%
Description
Since we only support Jewel and later releases, which both support object-map and fast-diff, enabling/disabling object-map should always enable/disable fast-diff.
Updated by Mao Zhongyi almost 6 years ago
Hi, Jason
I implemented this feature. Please review it.
Thank you very much.
Updated by Mao Zhongyi almost 6 years ago
Mao Zhongyi wrote:
Hi, Jason
I implemented this feature. Please review it.
Thank you very much.
Submit this patch by PR.
URL: https://github.com/ceph/ceph/pull/21969.
Updated by Jason Dillaman almost 6 years ago
- Status changed from New to Resolved
Updated by Patrick Seidensal almost 5 years ago
- Related to Feature #39451: mgr/dashboard: Interlock `fast-diff` and `object-map` added
Updated by Ricardo Marques almost 5 years ago
In Nautilus, I cannot create an image with `object-map` and without `fast-diff` because `object-map` will now implicitly enable `fast-diff`, but after creating the image I can disable the `fast-diff` explicitly using the `rbd disable` feature and end up with an image with `object-map` enabled and `fast-diff` disabled. Is this the excepted behaviour or is this a bug?
Updated by Ricardo Marques almost 5 years ago
My main question here is, from a Ceph Dashboard point of view, can we simply drop the `fast-diff` checkbox from the RBD form, or do we still have to show the `fast-diff` checkbox when user is editing an image, so he is able to disable `fast-diff` only?
Updated by Jason Dillaman almost 5 years ago
@Ricardo Rocha: it sounds like a bug if you can disable fast-diff and leave object-map enabled. The dashboard should probably just show "object-map/fast-diff" as a single checkbox. The only trouble I can think of is if you have a legacy image w/ just "object-map" enabled, how would the dashboard show this partial state? Given that, perhaps it would be better if they are kept separate but checking/unchecking one dynamically checks/unchecks the other.
Updated by Lenz Grimmer almost 5 years ago
- Related to Bug #39521: Fast-diff can be disabled w/o disabling object-map added