Project

General

Profile

Bug #24033

rados: not all exceptions accept keyargs

Added by Rishabh Dave 9 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
05/07/2018
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
luminous, mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
rados tool
Pull request ID:

Description

The method make_ex() in rados.pyx raises exceptions irrespective of the fact whether an exception can or cannot handle keyargs. Getting an exception that doesn't inherits OSError leads to a crash with traceback like the following: -

Connecting to RADOS with config /home/centos/repos/ceph/build/ceph.conf...
Traceback (most recent call last):
  File "test.py", line 49, in <module>
    header()
  File "test.py", line 14, in header
    vc.connect()
  File "/home/centos/repos/ceph/src/pybind/ceph_volume_client.py", line 458, in connect
    self.rados.connect()
  File "rados.pyx", line 884, in rados.Rados.connect (rados.c:9790)
  File "rados.pyx", line 463, in rados.make_ex (rados.c:3228)
TypeError: InvalidArgumentError does not take keyword arguments
disconnect
Disconnecting rados...
Disconnecting rados complete

Only the bunch of exceptions inheriting OSError in ceph/src/pybind/rados/rados.pyx are capable of handling keyargs.


Related issues

Copied to RADOS - Backport #24083: luminous: rados: not all exceptions accept keyargs Resolved
Copied to RADOS - Backport #25178: mimic: rados: not all exceptions accept keyargs Resolved

History

#1 Updated by Rishabh Dave 9 months ago

  • Project changed from fs to Ceph

#3 Updated by Patrick Donnelly 9 months ago

  • Project changed from Ceph to RADOS
  • Status changed from New to Need Review
  • Target version set to v13.2.0
  • Source set to Development
  • Backport set to luminous
  • Component(RADOS) rados tool added

#4 Updated by Kefu Chai 9 months ago

  • Status changed from Need Review to Pending Backport

#5 Updated by Nathan Cutler 9 months ago

  • Copied to Backport #24083: luminous: rados: not all exceptions accept keyargs added

#6 Updated by Nathan Cutler 6 months ago

  • Backport changed from luminous to luminous, mimic

#7 Updated by Nathan Cutler 6 months ago

  • Copied to Backport #25178: mimic: rados: not all exceptions accept keyargs added

#8 Updated by Nathan Cutler 5 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF