Project

General

Profile

Actions
Copy link

Bug #24030

closed

ceph-fuse: double dash meaning

Added by Jos Collin almost 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jos Collin
Category:
Administration/Usability
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

jcollin@stratocaster:~$ grep -- -v file1 
-v

jcollin@stratocaster:~/workspace/cephtest/build$ sudo ./bin/ceph-fuse  --localize-reads -- -m localhost:40331 /mnt/cephfs/
2018-05-07 10:03:51.958 7f60edcf1c40 -1 WARNING: all dangerous and experimental features are enabled.
2018-05-07 10:03:51.966 7f60edcf1c40 -1 WARNING: all dangerous and experimental features are enabled.
setting CEPH_OSD_FLAG_LOCALIZE_READS
2018-05-07 10:03:51.966 7f60edcf1c40 -1 WARNING: all dangerous and experimental features are enabled.
2018-05-07 10:03:51.966 7f60edcf1c40 -1 init, newargv = 0x561177dce3e0 newargc=9
fuse: bad mount point `localhost:40331': No such file or directory
ceph-fuse[2018-05-07 10:03:51.966 7f60edcf1c40 -1 fuse_parse_cmdline failed.
15994]: fuse failed to initialize

If we don't have a requirement to change the meaning of the next parameter, then what is the actual meaning of a double dash here? I'm able to find only failures when using a double dash. So drop the double dash? (I think this should be verified with other commands too common, as double dash is used everywhere).

Also for ceph-fuse, the double dash cannot be the end of all options. For instance, the check for '-m' is somewhere outside the loop.
https://github.com/ceph/ceph/blob/9b8a74f0372202f7d88be5fe8a7c37b53e913605/src/ceph_fuse.cc#L114

Actions
Copy link
 #1

Updated by Patrick Donnelly almost 6 years ago

  • Assignee set to Jos Collin
  • Target version set to v14.0.0

Jos, please take a crack at fixing this. Thanks!

Actions
Copy link
 #3

Updated by Patrick Donnelly almost 6 years ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #4

Updated by Jos Collin over 5 years ago

  • Status changed from Fix Under Review to In Progress
Actions
Copy link
 #5

Updated by Jos Collin over 5 years ago

  • Status changed from In Progress to New
Actions
Copy link
 #6

Updated by Patrick Donnelly about 5 years ago

  • Target version changed from v14.0.0 to v15.0.0
Actions
Copy link
 #7

Updated by Patrick Donnelly about 4 years ago

  • Target version deleted (v15.0.0)
Actions
Copy link
 #8

Updated by Jos Collin over 2 years ago

  • Status changed from New to Closed

Closing this because:

  • In the review, disabling -- is not encouraged.
  • When I look at this issue now, this doesn't really falls within the scope of improving cephfs and this must be more like a generic thing. So it won't be worth putting effort on this.
Actions
Copy link

Also available in: Atom PDF