Project

General

Profile

Actions

Feature #23979

closed

Limit pg log length during recovery/backfill so that we don't run out of memory.

Added by David Zafman almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
mimic, luminous
Reviewed:
Affected Versions:
Component(RADOS):
Pull request ID:

Description

This means if there's another failure, we'll need to restart backfill or go from recovery to backfill, but that's better than running out of memory.

Treating osd_max_pg_log_entries as a hard cap should be sufficient.


Related issues 4 (0 open4 closed)

Related to RADOS - Bug #25198: FAILED assert(trim_to <= info.last_complete) in PGLog::trim()ResolvedNeha Ojha07/31/2018

Actions
Related to RADOS - Bug #26868: PGLog.cc: saw valgrind issues while accessing complete_to->versionResolvedNeha Ojha08/06/2018

Actions
Copied to RADOS - Backport #24988: luminous: Limit pg log length during recovery/backfill so that we don't run out of memory.ResolvedNeha OjhaActions
Copied to RADOS - Backport #24989: mimic: Limit pg log length during recovery/backfill so that we don't run out of memory.ResolvedNeha OjhaActions
Actions #1

Updated by David Zafman almost 6 years ago

  • Source set to Development
  • Backport set to luminous
Actions #2

Updated by David Zafman almost 6 years ago

  • Assignee changed from David Zafman to Josh Durgin
Actions #3

Updated by Josh Durgin almost 6 years ago

  • Assignee changed from Josh Durgin to Neha Ojha

Initial testing is referenced here: https://github.com/ceph/ceph/pull/21508

Actions #4

Updated by Josh Durgin almost 6 years ago

  • Backport changed from luminous to mimic, luminous
Actions #5

Updated by Neha Ojha almost 6 years ago

  • Status changed from 12 to Fix Under Review
Actions #6

Updated by Josh Durgin over 5 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #7

Updated by Nathan Cutler over 5 years ago

  • Copied to Backport #24988: luminous: Limit pg log length during recovery/backfill so that we don't run out of memory. added
Actions #8

Updated by Nathan Cutler over 5 years ago

  • Copied to Backport #24989: mimic: Limit pg log length during recovery/backfill so that we don't run out of memory. added
Actions #9

Updated by Neha Ojha over 5 years ago

  • Related to Bug #25198: FAILED assert(trim_to <= info.last_complete) in PGLog::trim() added
Actions #10

Updated by Neha Ojha over 5 years ago

  • Related to Bug #26868: PGLog.cc: saw valgrind issues while accessing complete_to->version added
Actions #11

Updated by Nathan Cutler over 5 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF