Cleanup #2331
Makefile.am:182: `lib/libgtest.a' is not a standard libtool library name
| Status: | Resolved | Start date: | 04/23/2012 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | - | Spent time: | - | |
| Target version: | v0.48 | |||
| Tags: | Reviewed: | |||
| Story points | - | |||
| Velocity based estimate | - |
Description
Warning is still happening, despite git clean -fdx, git submodule freshening of various sorts, etc.
This should probably be investigated; build errors are offputting as a first impression.
Associated revisions
Makefile: link gtest statically
The problem:
- rbd and rados api unit tests link against gtest, and are installed
- the unittests link against gtest and are not
- if we build gtest as an .la library, we can only control whether all
or no .la libraries are linked statically.
- we want librados to be linked dynamicallyThe solution:
- build gtest as .a instead of a libtool library
- link it statically, always.Unit test binaries are bigger now. Oh well...
Fixes: #2331
Signed-off-by: Sage Weil <sage@inktank.com>
Makefile: link gtest statically
The problem:
- the unittests link against gtest, and gtest is not installed. that's
normally fine, but...
- rbd and rados api unit tests link against gtest, and are installed
by 'make install'. they are needed for teuthology runs, etc.
- if we build gtest as an .la library, we can only control whether all
or no .la libraries are linked statically.
- we want librados to be linked dynamically.The solution:
- build gtest as .a instead of a libtool library
- link it statically, always.Unit test binaries are bigger now. Oh well...
Fixes: #2331
Signed-off-by: Sage Weil <sage@inktank.com>
Makefile: link gtest statically
The problem:
- the unittests link against gtest, and gtest is not installed. that's
normally fine, but...
- rbd and rados api unit tests link against gtest, and are installed
by 'make install'. they are needed for teuthology runs, etc.
- if we build gtest as an .la library, we can only control whether all
or no .la libraries are linked statically.
- we want librados to be linked dynamically.The solution:
- build gtest as .a instead of a libtool library
- link it statically, always.Unit test binaries are bigger now. Oh well...
Fixes: #2331
Signed-off-by: Sage Weil <sage@inktank.com>