Bug #22546: client: dirty caps may never get the chance to flush - CephFS - Ceph

Actions

Copy link

Bug #22546

closed

client: dirty caps may never get the chance to flush

Added by dongdong tao over 6 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

dongdong tao

Category:

Target version:

% Done:

Source:

Tags:

Backport:

luminous,jewel

Regression:

Severity:

2 - major

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Client

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

currently, we flush the caps in function Client::flush_caps_sync
but there is a bug in this funcion.

because the two list delayed_caps and cap_list shared the same inode item.
so one dirty inode should always exist in one of them, otherwise, the dirty caps would never be flushed.
but in this function, when we first pop an inode item out from the list "delayed_caps", and it was not added to cap_list
later maybe this inode got dirty caps again, and we call unmount/sync_fs -> flush_caps_sync.
this time that inode's dirty cap would not be flushed at all.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by dongdong tao over 6 years ago

https://github.com/ceph/ceph/pull/19703

Actions

Copy link

Updated by Jos Collin over 6 years ago

Assignee set to dongdong tao

Actions

Copy link

Updated by Patrick Donnelly over 6 years ago

Subject changed from dirty caps may never get the chance to flush to client: dirty caps may never get the chance to flush
Status changed from New to Fix Under Review
Backport set to luminous,jewel
Component(FS) Client added