Project

General

Profile

Bug #22207

ceph-disk flake8 test fails on very old, and very new, versions of flake8

Added by Nathan Cutler 25 days ago. Updated 18 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
11/21/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous,jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

Very old, and very new, versions of flake8 treat E722 as an error:

flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:1575:9: E722 do not use bare except'
ceph_disk/main.py:1582:9: E722 do not use bare except'
ceph_disk/main.py:3252:5: E722 do not use bare except'
ceph_disk/main.py:3288:21: E722 do not use bare except'
ceph_disk/main.py:3296:17: E722 do not use bare except'
ceph_disk/main.py:4358:5: E722 do not use bare except'
tests/test_main.py:26:1: E722 do not use bare except'
ERROR: InvocationError: '/opt/j/ws/mkck/src/ceph-disk/.tox/flake8/bin/flake8 --ignore=H105,H405,E127 ceph_disk tests'

(This does not happen when running make check via Jenkins, but it should be very easy to reproduce using different versions of flake8.)

References: https://gitlab.com/pycqa/flake8/issues/361


Related issues

Copied to Ceph - Backport #22235: luminous: ceph-disk flake8 test fails on very old, and very new, versions of flake8 Resolved
Copied to Ceph - Backport #22236: jewel: ceph-disk flake8 test fails on very old, and very new, versions of flake8 Resolved

History

#1 Updated by Nathan Cutler 25 days ago

  • Description updated (diff)

#2 Updated by Nathan Cutler 25 days ago

  • Backport set to luminous,jewel

#3 Updated by Nathan Cutler 25 days ago

  • Description updated (diff)

#4 Updated by Nathan Cutler 25 days ago

  • Status changed from New to Need Review

#5 Updated by Kefu Chai 25 days ago

  • Status changed from Need Review to Pending Backport

#6 Updated by Nathan Cutler 22 days ago

  • Copied to Backport #22235: luminous: ceph-disk flake8 test fails on very old, and very new, versions of flake8 added

#7 Updated by Nathan Cutler 22 days ago

  • Copied to Backport #22236: jewel: ceph-disk flake8 test fails on very old, and very new, versions of flake8 added

#8 Updated by Nathan Cutler 18 days ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF