Project

General

Profile

Bug #21882

some kernels don't understand crush compat weight-set

Added by Sage Weil about 2 months ago. Updated 22 days ago.

Status:
Resolved
Priority:
Immediate
Assignee:
-
Category:
-
Target version:
-
Start date:
10/20/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

teuthology kernel is Linux teuthology 4.10.0-33-generic #37~16.04.1-Ubuntu SMP Fri Aug 11 14:07:24 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

on lab cluster, set a bunch of compat weight-set weights, and ios stalled.
osdc shows ops mapping to one osd, but ceph pg map maps to another.

probably the cluster isn't compat-encoding for the kernel's features?

'ceph osd crush weight-set rm-compat' resolves it. 'ceph balancer on' should retrigger it.


Related issues

Copied to Ceph - Backport #21917: luminous: some kernels don't understand crush compat weight-set Resolved

History

#1 Updated by Sage Weil about 2 months ago

I think this is the problem:

diff --git a/src/messages/MOSDMap.h b/src/messages/MOSDMap.h
index fa46189bf0..865642cf41 100644
--- a/src/messages/MOSDMap.h
+++ b/src/messages/MOSDMap.h
@@ -113,6 +113,14 @@ public:
          inc.fullmap.clear();
          m.encode(inc.fullmap, features | CEPH_FEATURE_RESERVED);
        }
+       if (inc.crush.length()) {
+         // embedded crush map
+         CrushWrapper c;
+         auto p = inc.crush.begin();
+         c.decode(p);
+         inc.crush.clear();
+         c.encode(inc.crush, features);
+       }
        inc.encode(p->second, features | CEPH_FEATURE_RESERVED);
       }
       for (map<epoch_t,bufferlist>::iterator p = maps.begin();

we weren't reencoding a compat version of the incrementals.. only the full maps.

#2 Updated by Sage Weil about 2 months ago

  • Status changed from Verified to Need Review
  • Backport set to luminous

#3 Updated by Sage Weil about 2 months ago

  • Status changed from Need Review to Pending Backport

#4 Updated by Nathan Cutler about 2 months ago

  • Copied to Backport #21917: luminous: some kernels don't understand crush compat weight-set added

#5 Updated by Nathan Cutler 22 days ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF