Actions
Bug #21664
closedBring back diff -y for non-FreeBSD
Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
luminous, mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Create a diff function in ceph-helpers.sh for osd-scrub-repair.sh and osd-scrub-snaps.sh that will output both a diff and a diff -y if appropriate when there are differences.
Updated by David Zafman over 6 years ago
This was the code removed by Sage
if [ `uname` = FreeBSD ]; then SED=gsed - DIFFCOLOPTS="" KERNCORE="kern.corefile" else SED=sed - termwidth=$(stty -a | head -1 | sed -e 's/.*columns \([0-9]*\).*/\1/') - if [ -n "$termwidth" -a "$termwidth" != "0" ]; then - termwidth="-W ${termwidth}" - fi - DIFFCOLOPTS="-y $termwidth" KERNCORE="kernel.core_pattern" fi
Updated by David Zafman almost 6 years ago
Updated by David Zafman almost 6 years ago
- Status changed from New to Fix Under Review
Updated by David Zafman almost 6 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Nathan Cutler almost 6 years ago
- Copied to Backport #24738: mimic: Bring back diff -y for non-FreeBSD added
Updated by Nathan Cutler almost 6 years ago
- Copied to Backport #24739: luminous: Bring back diff -y for non-FreeBSD added
Updated by David Zafman almost 6 years ago
Let's backport
https://github.com/ceph/ceph/pull/22702
https://github.com/ceph/ceph/pull/22763
https://github.com/ceph/ceph/pull/22480
in addition to the pull request for this tracker: https://github.com/ceph/ceph/pull/22727
Updated by David Zafman over 5 years ago
- Status changed from Pending Backport to Resolved
Actions