https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2017-09-27T14:57:55ZCeph RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=999262017-09-27T14:57:55ZJason Dillamandillaman@redhat.com
<ul><li><strong>Backport</strong> set to <i>luminous</i></li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=999272017-09-27T15:02:04ZJason Dillamandillaman@redhat.com
<ul><li><strong>Subject</strong> changed from <i>[upgrade] bufferlist ABI broken in luminous release</i> to <i>[upgrade] buffer::list ABI broken in luminous release</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/99927/diff?detail_id=96994">diff</a>)</li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=999282017-09-27T15:02:42ZJason Dillamandillaman@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/99928/diff?detail_id=96995">diff</a>)</li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1006022017-10-11T00:12:35ZJason Dillamandillaman@redhat.com
<ul><li><strong>Priority</strong> changed from <i>High</i> to <i>Urgent</i></li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1009202017-10-17T20:41:44ZYuri Weinsteinyweinste@redhat.com
<ul><li><strong>Assignee</strong> set to <i>Kefu Chai</i></li></ul><p>@Kefu can you pls take a look?</p> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1009972017-10-19T09:14:39ZKefu Chaitchaikov@gmail.com
<ul></ul><p>this would be a little bit tricky:</p>
<pre><code class="cpp syntaxhl"><span class="CodeRay"> <span class="keyword">class</span> <span class="class">CEPH_BUFFER_API</span> list {
<span class="preprocessor"># </span>..
<span class="predefined-type">int</span> _mempool = -<span class="integer">1</span>;
<span class="preprocessor"># </span>..
<span class="directive">public</span>:
<span class="comment">// cons/des</span>
list() : _len(<span class="integer">0</span>), _memcopy_count(<span class="integer">0</span>), last_p(<span class="local-variable">this</span>) {}
<span class="comment">// cppcheck-suppress noExplicitConstructor</span>
list(<span class="predefined-type">unsigned</span> prealloc) : _len(<span class="integer">0</span>), _memcopy_count(<span class="integer">0</span>), last_p(<span class="local-variable">this</span>) {
reserve(prealloc);
}
<span class="comment">// ...</span>
};
</span></code></pre>
<p>so the constructors are inlined, and are not defined in librados. that's why <code>_mempool</code> is not initialized by the old clients, which are still using their own copies of the ctors.</p>
<p>and we have <b>no</b> way to change the behavior of the inlined constructors.</p>
<p>so i'd suggest bump up the so version of librados. will send a mail to ceph-devel asking for more opinions.</p> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1010012017-10-19T09:30:58ZKefu Chaitchaikov@gmail.com
<ul><li><strong>Duplicated by</strong> <i><a class="issue tracker-1 status-10 priority-4 priority-default closed" href="/issues/21352">Bug #21352</a>: librados version should bump major number when ABI changes</i> added</li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1010752017-10-20T05:30:04ZKefu Chaitchaikov@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fix Under Review</i></li><li><strong>Assignee</strong> changed from <i>Kefu Chai</i> to <i>Sage Weil</i></li><li><strong>Component(RADOS)</strong> <i>librados</i> added</li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/18408">https://github.com/ceph/ceph/pull/18408</a></p> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1012402017-10-23T15:53:06ZSage Weilsage@newdream.net
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Pending Backport</i></li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1012622017-10-24T03:52:59ZKefu Chaitchaikov@gmail.com
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-6 priority-high2 closed" href="/issues/21899">Backport #21899</a>: luminous: [upgrade] buffer::list ABI broken in luminous release</i> added</li></ul> RADOS - Bug #21573: [upgrade] buffer::list ABI broken in luminous releasehttps://tracker.ceph.com/issues/21573?journal_id=1012652017-10-24T03:53:28ZKefu Chaitchaikov@gmail.com
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul>