Project

General

Profile

Bug #21083

client: clean up header to isolate real public methods and entry points for client_lock

Added by Patrick Donnelly over 1 year ago. Updated 8 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Correctness/Safety
Target version:
Start date:
08/23/2017
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:

Description

With the recent revelation that the client_lock was not locked for Client::getcwd [1] and other history of missing locks [2], we should take the time to cleanup Client.h (and Client.cc) and verify that all public methods get the required locks. If it followed the current header organization coding standards, it would be easier to verify. Additionally, some methods which are public should probably be private.

[1] http://tracker.ceph.com/issues/21082
[2] https://github.com/ceph/ceph/pull/10027

History

#1 Updated by Patrick Donnelly over 1 year ago

Should be reorganized with an eye toward finer grained locks, along with a client_lock audit. -Jeff

#2 Updated by Patrick Donnelly 8 months ago

  • Target version changed from v13.0.0 to v14.0.0

Also available in: Atom PDF