Project

General

Profile

Bug #20899

prometheus module generates invalid output when counter names contain non-alphanum characters

Added by John Spray 5 months ago. Updated 3 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
-
Category:
prometheus module
Target version:
-
Start date:
08/03/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

When I enabled an MDS, I found that prometheus threw an error scraping our stats. I assume it's due to counter names (maybe the ones that have a plus/minus sign in them?)


Related issues

Copied to mgr - Backport #21452: luminous: prometheus module generates invalid output when counter names contain non-alphanum characters Resolved

History

#1 Updated by John Spray 5 months ago

  • Category set to prometheus module

#2 Updated by Jeremy Austin 4 months ago

I created an account just so I could submit this bug… so I concur,

mds_mem_cap+ is an example (the first sequentially) of one on which prometheus choked.

I propose:

https://github.com/ceph/ceph/compare/master...jermudgeon:patch-1

#3 Updated by John Spray 4 months ago

  • Status changed from New to Need Review
  • Backport set to luminous

Thanks for the patch, I took the liberty of turning it into a pull request here:

https://github.com/ceph/ceph/pull/17310

#4 Updated by Jeremy Austin 4 months ago

Thanks, John — I wasn't sure which branch to create the pull request on, luminous or master. Be gentle with me, it's my first time :)

#6 Updated by John Spray 3 months ago

  • Status changed from Need Review to Pending Backport

#7 Updated by Nathan Cutler 3 months ago

  • Copied to Backport #21452: luminous: prometheus module generates invalid output when counter names contain non-alphanum characters added

Also available in: Atom PDF