Feature #20607: MDSMonitor: change "mds deactivate" to clearer "mds rejoin" - CephFS - Ceph

Actions

Copy link

Feature #20607

closed

Feature #20606: mds: improve usability of cluster rank manipulation and setting cluster up/down

MDSMonitor: change "mds deactivate" to clearer "mds rejoin"

Added by Patrick Donnelly almost 7 years ago. Updated about 6 years ago.

Status:

Rejected

Priority:

Urgent

Assignee:

Douglas Fuller

Category:

Administration/Usability

Target version:

Ceph - v13.0.0

% Done:

Source:

Tags:

Backport:

Reviewed:

Affected Versions:

Component(FS):

MDSMonitor

Labels (FS):

multimds

Pull request ID:

Description

Rename `ceph mds deactivate` to `ceph mds rejoin`. This makes it clear an MDS is leaving and then rejoining the metadata cluster. It is not "deactivating" which to me means shutting down gently and not coming back. Running rejoin on a rank which will not result in the cluster shrinking (because max_mds has not changed) is now okay.

Actions

Copy link

Updated by John Spray almost 7 years ago

The trouble with "rejoin" is that it's also the name of one of the states the daemon passes through during startup.

Actions

Copy link

Updated by Zheng Yan almost 7 years ago

I agree with john. rejoin is confusing for non-native English speaker

Actions

Copy link

Updated by Patrick Donnelly almost 7 years ago

Agreed on "rejoin".

Okay so after a jog and some light thought, I would suggest "release" (i.e. the rank is released) or "flush" (i.e. the rank's session/journal is flushed).

In any case, this sub-ticket of #20606 interests me least so if no one thinks this is really worth changing, I'll close this.

Actions

Copy link

Updated by Nathan Cutler almost 7 years ago

I like "flush". Also, "reactivate" occurred to me.

Actions

Copy link

Updated by Douglas Fuller almost 7 years ago

I think "reset" would work well. I do think we should change it, though.

Actions

Copy link

Updated by Jan Fajerski over 6 years ago

I don't find deactivate so bad since this commands primarily deals with ranks (that just happened to be backed by a certain mds) iiuc. So if I'm not totally mistaken I think deactivate could stay and a doc change would suffice. I was actually about to propose this change.

Actions

Copy link