Project

General

Profile

Bug #20488

ceph-disk dmcrypt does not unlock blockdevice for bluestore

Added by Felix Winterhalter 6 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Urgent
Category:
OSD
Target version:
-
Start date:
07/03/2017
Due date:
% Done:

0%

Estimated time:
1.00 h
Source:
Community (user)
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
ceph-disk
Release:
Needs Doc:
No

Description

The ceph-disk utility does not unlock the blockdevice when called with --dmcrypt for bluestore.

It will unlock the osd data directory alright using the lockbox but then neglect to unlock the blockdevice itself. Causing the OSD to fail without access to the block device.

The fix should be simple enough by adding in a detection whether the block_dmcrypt link exists in the OSD directory and then proceed to unlock that. Alternatively check whether it is a bluestore OSD and then unlock the second partition using the same key.

I can prepare a pull request to solve that problem if wanted.


Related issues

Copied to Ceph - Backport #21974: luminous: ceph-disk dmcrypt does not unlock blockdevice for bluestore Resolved

History

#1 Updated by Sage Weil 5 months ago

  • Status changed from New to Verified
  • Priority changed from Normal to Urgent

A pull request fixing this would be most appreciated, thanks!

#2 Updated by Kefu Chai 5 months ago

  • Status changed from Verified to Need Review
  • Assignee set to Felix Winterhalter

#3 Updated by Kefu Chai 4 months ago

  • Status changed from Need Review to Resolved
  • Target version deleted (v12.1.0)

#4 Updated by Nathan Cutler about 2 months ago

  • Status changed from Resolved to Pending Backport
  • Backport set to luminous

This just missed the v12.2.0 cutoff. Kefu opened luminous backport PR: https://github.com/ceph/ceph/pull/18625

#5 Updated by Nathan Cutler about 2 months ago

  • Copied to Backport #21974: luminous: ceph-disk dmcrypt does not unlock blockdevice for bluestore added

#6 Updated by Nathan Cutler about 1 month ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF