Project

General

Profile

Fix #20425

build/ops: rpm: some build dependencies are only needed for running "make check", not for the build itself

Added by Nathan Cutler 6 months ago. Updated 6 months ago.

Status:
Need Review
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
06/27/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

Some dependencies - notably the mgr dependencies "python-cherrypy", "python-pecan" and "python-werkzeug" - are only needed to run "make check". Since these dependencies bring in a pretty long list of packages (dependencies of dependencies of dependencies. . .) it would make sense to put them inside the "make_check" bcond so RPM builds that do not run "make check" (the default) would not pull in all these python modules that are not used.

There is one wrinkle, though: the bcond is "off" by default, so install-deps.sh will need to activate it before parsing the spec file for dependencies, otherwise "run-make-check.sh" will fail due to missing dependencies.

History

#1 Updated by Nathan Cutler 6 months ago

  • Description updated (diff)

#2 Updated by Nathan Cutler 6 months ago

  • Status changed from New to Need Review

#3 Updated by Nathan Cutler 6 months ago

  • Subject changed from build/ops: rpm: some build dependencies are only needed for running "make check" to build/ops: rpm: some build dependencies are only needed for running "make check", not for the build itself

Also available in: Atom PDF