Project

General

Profile

Bug #20417

Unexpected rgw task override keys cause bogus test failures

Added by Nathan Cutler over 1 year ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
06/26/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

The "qa/tasks/rgw.py" task expects to get a list of client roles in the task config. Via the override mechanism the task config may also include unrelated keys - i.e. keys that do not signify a client role. The idea is that rgw.py task pops these unrelated keys out of config and puts them into "ctx.rgw", but it only does this for keys that it expects to find. If any other key is present, the create_pools() function attempts to treat it as a role and fails.

For example, this config contains an unexpected key that did not get popped:

DEBUG:tasks.rgw:config is {'client.0': None, 'default_idle_timeout': 1200}

As a result, the test fails in create_pools() on the second iteration over the config keys:

2017-06-26 08:57:49,290.290 INFO:tasks.rgw:Creating data pools
2017-06-26 08:57:49,290.290 DEBUG:tasks.rgw:Obtaining remote for client client.0
2017-06-26 08:57:49,291.291 INFO:teuthology.orchestra.run.target149202179085:Running: 'sudo ceph osd erasure-code-profile set client.0 k=2 m=1 ruleset-failure-domain=osd --cluster ceph'
2017-06-26 08:57:50,111.111 INFO:teuthology.orchestra.run.target149202179085:Running: 'sudo ceph osd pool create .rgw.buckets 64 64 erasure client.0 --cluster ceph'
2017-06-26 08:57:52,310.310 INFO:teuthology.orchestra.run.target149202179085.stderr:pool '.rgw.buckets' created
2017-06-26 08:57:52,325.325 INFO:teuthology.orchestra.run.target149202179085:Running: 'sudo ceph osd pool create .rgw.buckets.cache 64 --cluster ceph'
2017-06-26 08:57:53,564.564 INFO:teuthology.orchestra.run.target149202179085.stderr:pool '.rgw.buckets.cache' created
2017-06-26 08:57:53,583.583 INFO:teuthology.orchestra.run.target149202179085:Running: 'sudo ceph osd tier add-cache .rgw.buckets .rgw.buckets.cache 67108864 --cluster ceph'
2017-06-26 08:57:54,896.896 INFO:teuthology.orchestra.run.target149202179085.stderr:pool '.rgw.buckets.cache' is now (or already was) a cache tier of '.rgw.buckets'
2017-06-26 08:57:54,908.908 DEBUG:tasks.rgw:Obtaining remote for client default_idle_timeout
2017-06-26 08:57:54,909.909 ERROR:teuthology.contextutil:Saw exception from nested tasks
Traceback (most recent call last):
  File "/home/ubuntu/teuthology/teuthology/contextutil.py", line 30, in nested
    vars.append(enter())
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/ubuntu/src/github.com_SUSE_ceph_wip-rgw-keys/qa/tasks/rgw.py", line 139, in create_pools
    (remote,) = ctx.cluster.only(client).remotes.iterkeys()
ValueError: need more than 0 values to unpack

History

#1 Updated by Nathan Cutler over 1 year ago

  • Status changed from New to Need Review

#2 Updated by Nathan Cutler 4 months ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF