Bug #20112: Use boost::regex instead of std::regex for rgw_iam_policy.cc and rgw_role.cc - rgw - Ceph

Actions

Copy link

Bug #20112

closed

Use boost::regex instead of std::regex for rgw_iam_policy.cc and rgw_role.cc

Added by Brad Hubbard almost 7 years ago. Updated over 6 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Adam Emerson

Target version:

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

src/rgw/rgw_iam_policy.cc and src/rgw/rgw_role.cc include code that uses the std::regex header.

Per https://bugzilla.redhat.com/show_bug.cgi?id=1180035#c1 and other resources <regex> is not implemented in gcc 4.8 and rhel7/CentOS7 and this code will likely not work as expected.

The code should be changed to work with boost::regex which should be more universally available.

Actions

Copy link

Updated by Greg Farnum almost 7 years ago

please dont just do a search-and-replace. Put a regex in the ceph:: namespace so we can map it to the right thing depending on our environment. this worked really well for smart pointers!

Actions

Copy link

Updated by Kefu Chai almost 7 years ago

i confirm this issue. i also found that that gcc 4.8's regex implementation was buggy and incomplete the hard way.

couple weeks ago, i was trying to replace the boost::regex with std::regex, but some rbd tests just failed. after some researching, i had the same finding as Brad.

Actions

Copy link