Bug #19883
Remove redundant includes
% Done:
0%
Spent time:
Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Ceph source files contain many redundant #includes. Removing these should, in theory, improve compilation times and reduce dependencies.
History
#1 Updated by Brad Hubbard almost 7 years ago
- Status changed from New to In Progress
#3 Updated by Willem Jan Withagen almost 7 years ago
Brad,
How did you get these redundancies?
Just running GCC on Linux?
Having a lot of fallout under FreeBSD/Clang
#4 Updated by Brad Hubbard almost 7 years ago
Hi Willem,
Which PRs/commits specifically are you having issues with?
I don't have access to FreeBSD to test with.
#5 Updated by Willem Jan Withagen almost 7 years ago
Willem Jan Withagen wrote:
Willem Jan Withagen wrote:
Brad,
How did you get these redundancies?
Just running GCC on Linux?Having a lot of fallout under FreeBSD/Clang
Fix the missing includes in
https://github.com/ceph/ceph/pull/15337
#6 Updated by Willem Jan Withagen almost 7 years ago
https://github.com/ceph/ceph/pull/15685
core/common: Fix ENODATA for FreeBSD with compat.h
- When ENODATA used, compat.h needs to be include before any
of the includes that could possibly define ENODATA by itself.
Since otherwise xattr-tests will fail to detect that attributes
are (not) there.
#7 Updated by Brad Hubbard about 6 years ago
- Status changed from In Progress to Closed