Project

General

Profile

Bug #19883

Remove redundant includes

Added by Brad Hubbard 3 months ago. Updated 2 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
05/09/2017
Due date:
% Done:

0%

Spent time:
Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

Ceph source files contain many redundant #includes. Removing these should, in theory, improve compilation times and reduce dependencies.

History

#3 Updated by Willem Jan Withagen 3 months ago

Brad,

How did you get these redundancies?
Just running GCC on Linux?

Having a lot of fallout under FreeBSD/Clang

#4 Updated by Brad Hubbard 3 months ago

Hi Willem,

Which PRs/commits specifically are you having issues with?

I don't have access to FreeBSD to test with.

#5 Updated by Willem Jan Withagen 3 months ago

Willem Jan Withagen wrote:

Willem Jan Withagen wrote:

Brad,

How did you get these redundancies?
Just running GCC on Linux?

Having a lot of fallout under FreeBSD/Clang

Fix the missing includes in
https://github.com/ceph/ceph/pull/15337

#6 Updated by Willem Jan Withagen 2 months ago

https://github.com/ceph/ceph/pull/15685

core/common: Fix ENODATA for FreeBSD with compat.h

- When ENODATA used, compat.h needs to be include before any
of the includes that could possibly define ENODATA by itself.
Since otherwise xattr-tests will fail to detect that attributes
are (not) there.

Also available in: Atom PDF