master does not build on s390x (regression)
After https://github.com/ceph/ceph/pull/14248 was merged, ceph no longer builds on ppc64le and s390x. In both cases the build failure is
[ 1035s] [ 26%] Building CXX object src/CMakeFiles/common-objs.dir/common/simple_spin.cc.o [ 1035s] /home/abuild/rpmbuild/BUILD/ceph-12.0.1+git.1491313394.3372162/src/common/simple_spin.cc:38:2: error: #error "Unknown architecture" [ 1035s] #error "Unknown architecture" [ 1035s] ^ [ 1035s] src/CMakeFiles/common-objs.dir/build.make:2415: recipe for target 'src/CMakeFiles/common-objs.dir/common/simple_spin.cc.o' failed [ 1035s] make: *** [src/CMakeFiles/common-objs.dir/common/simple_spin.cc.o] Error 1
#2 Updated by Brad Hubbard over 1 year ago
https://github.com/ceph/ceph/pull/14310 hopefully fixes ppc64le.
I wasn't even aware anyone was building on s390x and have no idea what the relevant assembly would be. A quick fix would be to fall back to the old code if we detect s390x (let me know if you'd like me to do this), otherwise I would welcome any patches you might be able to come up with as that arch is not something I've had a lot to do with.
#4 Updated by Nathan Cutler over 1 year ago
- Subject changed from master does not build on ppc64le and s390x (regression) to master does not build on s390x (regression)
- Assignee changed from Brad Hubbard to Nathan Cutler
Thanks, Brad. Confirm that PR#14310 fixes the ppc64le build.
Reassigning issue to myself for the s390x fix (I will ask the experts). @Kefu, did you mean maybe we can use "diag 44" or "diag 68" for yield on s390x??