Project

General

Profile

Bug #19492

master does not build on s390x (regression)

Added by Nathan Cutler 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
04/04/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

After https://github.com/ceph/ceph/pull/14248 was merged, ceph no longer builds on ppc64le and s390x. In both cases the build failure is

[ 1035s] [ 26%] Building CXX object src/CMakeFiles/common-objs.dir/common/simple_spin.cc.o
[ 1035s] /home/abuild/rpmbuild/BUILD/ceph-12.0.1+git.1491313394.3372162/src/common/simple_spin.cc:38:2: error: #error "Unknown architecture" 
[ 1035s]  #error "Unknown architecture" 
[ 1035s]   ^
[ 1035s] src/CMakeFiles/common-objs.dir/build.make:2415: recipe for target 'src/CMakeFiles/common-objs.dir/common/simple_spin.cc.o' failed
[ 1035s] make[2]: *** [src/CMakeFiles/common-objs.dir/common/simple_spin.cc.o] Error 1

History

#1 Updated by Nathan Cutler 4 months ago

Brad, if you like, I can consult this with the SUSE Labs guys and put together a fix.

#2 Updated by Brad Hubbard 4 months ago

https://github.com/ceph/ceph/pull/14310 hopefully fixes ppc64le.

I wasn't even aware anyone was building on s390x and have no idea what the relevant assembly would be. A quick fix would be to fall back to the old code if we detect s390x (let me know if you'd like me to do this), otherwise I would welcome any patches you might be able to come up with as that arch is not something I've had a lot to do with.

Thanks Nathan.

#3 Updated by Kefu Chai 4 months ago

maybe we can use "diag 44" or "diag 68" for yield. i found it in the linux kernel.

#4 Updated by Nathan Cutler 4 months ago

  • Subject changed from master does not build on ppc64le and s390x (regression) to master does not build on s390x (regression)
  • Assignee changed from Brad Hubbard to Nathan Cutler

Thanks, Brad. Confirm that PR#14310 fixes the ppc64le build.

Reassigning issue to myself for the s390x fix (I will ask the experts). @Kefu, did you mean maybe we can use "diag 44" or "diag 68" for yield on s390x??

#5 Updated by Nathan Cutler 4 months ago

  • Status changed from New to Need Review

#6 Updated by Nathan Cutler 4 months ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF