Project

General

Profile

Actions

Feature #19384

open

ceph_objectstore_tool (set|clear)-missing-item command

Added by Samuel Just about 7 years ago. Updated almost 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Introspection/Control
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Component(RADOS):
objectstore-tool
Pull request ID:

Description

This one is only relevant for kraken and later. It would be good to have a command for directly manipulating a pg's missing set entries (the missing set is implicit pre-kraken).

Actions #1

Updated by Samuel Just about 7 years ago

  • Description updated (diff)
Actions #2

Updated by Chang Liu about 7 years ago

Hi, Sam

I looked at this problem, and find other problem.

➜  build git:(wip-18584-pg-info-dump) grep -nri MissingLoc ../src/   
../src/osd/PrimaryLogPG.cc:10186:void PG::MissingLoc::check_recovery_sources(const OSDMapRef& osdmap)
../src/osd/PG.h:320:  class MissingLoc {
../src/osd/PG.h:329:    explicit MissingLoc(PG *pg)
../src/osd/PG.cc:498:bool PG::MissingLoc::readable_with_acting(
../src/osd/PG.cc:516:void PG::MissingLoc::add_batch_sources_info(
../src/osd/PG.cc:534:bool PG::MissingLoc::add_source_info(

We don't use `MissingLoc` anywhere. Need we remove such codes?

Actions #3

Updated by Chang Liu about 7 years ago

Chang Liu wrote:

Hi, Sam

I looked at this problem, and find other problem.

[...]

We don't use `MissingLoc` anywhere. Need we remove such codes?

Oh, sorry. I found `missing_loc`.

Actions #4

Updated by Greg Farnum almost 7 years ago

  • Tracker changed from Bug to Feature
  • Project changed from Ceph to RADOS
  • Category set to Introspection/Control
  • Component(RADOS) objectstore-tool added
Actions

Also available in: Atom PDF