Project

General

Profile

Cleanup #19274

src/tools/rbd/action/Kernel.cc: ceph.git does not exist

Added by Shinobu Kinjo about 7 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Low
Assignee:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

283 static int do_kernel_map(const char *poolname, const char *imgname,
284 const char *snapname)
285 {
286 #if defined(WITH_KRBD)
287 struct krbd_ctx *krbd;
288 std::ostringstream oss;
289 char *devnode;
290 int r;
291
292 r = krbd_create_from_context(g_ceph_context, &krbd);
293 if (r < 0)
294 return r;
295
296 for (std::map<std::string, std::string>::iterator it = map_options.begin();
297 it != map_options.end(); ) {
298 // for compatibility with < 3.7 kernels, assume that rw is on by
299 // default and omit it even if it was specified by the user
300 // (see ceph.git commit fb0f1986449b)

``ceph.git`` needs to be updated appropriately. Because it does not exist.

History

#1 Updated by Jason Dillaman almost 7 years ago

  • Project changed from Ceph to rbd

#2 Updated by Jason Dillaman over 6 years ago

  • Status changed from New to Rejected
# git show fb0f1986449b

commit fb0f1986449b53908a6d17d4398270da64aa8f07
Author: Josh Durgin <josh.durgin@inktank.com>
Date:   Fri Nov 1 19:02:29 2013 -0700

    rbd: omit 'rw' option during map

    The ro and rw options were added in linux 3.7. To be compatible with
    older kernels, don't specify rw. The default will probably always be
    rw, so this should not present any problems in the future.

    Reported-by: nicolasc <nicolas.canceill@surfsara.nl>
    Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

...

Also available in: Atom PDF