Bug #18491
setup_rpm should notify about build status as early as possible
0%
Description
An attempt was made to fix this in https://github.com/ceph/ceph-build/pull/614, but that broke the rpm build because the operations on ceph.spec.in, namely
sed -e 's/@//g' < ceph.spec.in > $DIR/ceph.spec, moved across a cd, and operate on relative paths.
Several things ought to happen:
1) ceph.spec.in should be irrelevant to the build; although it's in the dist tarball, ceph.spec should serve for all purposes, as far as I can tell.
2) scripts that cd should refer to files with absolute paths to avoid this sort of brittleness.
History
#1 Updated by Alfredo Deza about 7 years ago
Can you clarify a bit more what #1 is? Do you mean that ceph.spec, as it comes from the tarball, should be consumed as-is? (instead of calling sed on ceph.spec.in)
#2 Updated by Dan Mick about 7 years ago
Yes, exactly; ceph.spec is in more-useful state as it has things substituted in it. yum-builddep may not care (probably doesn't), but it shouldn't have to do its own munging, anyway.
#3 Updated by David Galloway over 2 years ago
- Assignee set to David Galloway
#4 Updated by David Galloway over 2 years ago
- Status changed from New to Fix Under Review