https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2016-12-21T16:48:59ZCeph rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=832672016-12-21T16:48:59ZCasey Bodleycbodley@redhat.com
<ul><li><strong>Assignee</strong> set to <i>Casey Bodley</i></li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=832932016-12-21T19:31:02ZCasey Bodleycbodley@redhat.com
<ul></ul><p>looking at <a class="external" href="http://qa-proxy.ceph.com/teuthology/sage-2016-12-16_16:52:37-rgw-master---basic-smithi/639993/remote/smithi007/log/rgw.client.1.log.gz">http://qa-proxy.ceph.com/teuthology/sage-2016-12-16_16:52:37-rgw-master---basic-smithi/639993/remote/smithi007/log/rgw.client.1.log.gz</a>, I see that incremental sync was running when radosgw was shut down:</p>
<pre>
2016-12-16 20:13:58.946062 34a4b700 20 meta sync: incremental_sync:1605: shard_id=59 mdlog_marker=1_1481918963.277466_1349.1 max_marker=1_1481918963.277466_1349.1 sync_marker.marker=1_1481918963.277466_1349.1 period_marker=
2016-12-16 20:13:58.946127 34a4b700 20 run: stack=0x7555d160 is io blocked
2016-12-16 20:13:59.320313 3c844700 -1 received signal: Terminated from PID: 7322 task name: /usr/bin/python /bin/daemon-helper term valgrind --trace-children=no --child-silent-after-fork=yes --num-callers=50 --suppressions=/home/ubuntu/cephtest/valgrind.supp --xml=yes --xml-file=/var/log/ceph/valgrind/client.1.log --time-stamp=yes --tool=memcheck radosgw --rgw-frontends civetweb port=7281 --rgw-zone r1z1 -n client.1 -k /etc/ceph/ceph.client.1.keyring --log-file /var/log/ceph/rgw.client.1.log --rgw_ops_log_socket_path /home/ubuntu/cephtest/rgw.opslog.client.1.sock --foreground UID: 0
2016-12-16 20:13:59.322571 3c844700 1 handle_sigterm
2016-12-16 20:13:59.323874 8cc4980 -1 shutting down
2016-12-16 20:13:59.328940 3c844700 1 handle_sigterm set alarm for 120
2016-12-16 20:13:59.544463 34a4b700 0 ERROR: failed to clone shard, completion_mgr.get_next() returned ret=-125
2016-12-16 20:13:59.545388 34a4b700 5 run(): was stopped, exiting
</pre>
<p>This cancels the RGWMetaSyncShardCR before it can call collect_children() to drop its references to the stacks in the stack_to_pos map. RGWMetaSyncShardCR's destructor will need to make sure all references are dropped.</p> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=832942016-12-21T19:36:46ZCasey Bodleycbodley@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fix Under Review</i></li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/12605">https://github.com/ceph/ceph/pull/12605</a></p> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=832952016-12-21T19:37:04ZCasey Bodleycbodley@redhat.com
<ul><li><strong>Backport</strong> set to <i>jewel kraken</i></li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=842372017-01-16T18:48:47ZYehuda Sadehyehuda@redhat.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Pending Backport</i></li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=842442017-01-16T19:01:47ZCasey Bodleycbodley@redhat.com
<ul></ul><p>backported to kraken in <a class="external" href="https://github.com/ceph/ceph/pull/12949">https://github.com/ceph/ceph/pull/12949</a></p> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=843002017-01-17T08:35:16ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-4 priority-default closed" href="/issues/18563">Backport #18563</a>: jewel: leak from RGWMetaSyncShardCR::incremental_sync</i> added</li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=843022017-01-17T08:35:18ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-4 priority-default closed" href="/issues/18564">Backport #18564</a>: kraken: leak from RGWMetaSyncShardCR::incremental_sync</i> added</li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=850262017-01-27T22:36:57ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Backport</strong> changed from <i>jewel kraken</i> to <i>jewel, kraken</i></li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=866422017-02-23T15:23:26ZSage Weilsage@newdream.net
<ul><li><strong>Priority</strong> changed from <i>Immediate</i> to <i>Urgent</i></li></ul> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=874022017-03-08T19:47:52ZCasey Bodleycbodley@redhat.com
<ul></ul><p>both backports are resolved, can we close this one?</p> rgw - Bug #18300: leak from RGWMetaSyncShardCR::incremental_synchttps://tracker.ceph.com/issues/18300?journal_id=874192017-03-09T12:37:54ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul>