Project

General

Profile

Actions

Feature #18235

closed

os/filestore/HashIndex: be loud about splits

Added by Dan van der Ster over 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
OSD
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
jewel
Reviewed:
Affected Versions:
Pull request ID:

Description

This ML thread "[ceph-users] filestore_split_multiple hardcoded maximum" has coincided with ~1 week of slow requests on one of our clusters. After much debugging we finally tracked it down to filestore splitting.

It would have been much easier to understand the root cause if filestore splitting was verbose. Splitting is a rare but rather important event -- the OSD should be super verbose when it happens. (Otherwise, it simply looks like a filestore write is taking many 10s of seconds, which seems absurd).

So I'm sending this patch for comments. I'm not sure if the dout is needed in the _create function, and I didn't make the merges verbose yet (which I guess is also needed?)

If this makes it to master, I'd appreciate a backport to jewel. (filestore will lose relevance anyway in L and beyond).

PR: https://github.com/ceph/ceph/pull/12421


Related issues 1 (0 open1 closed)

Copied to Ceph - Backport #19183: jewel: os/filestore/HashIndex: be loud about splitsResolvedShinobu KinjoActions
Actions #1

Updated by Nathan Cutler over 7 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Nathan Cutler about 7 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #3

Updated by Nathan Cutler about 7 years ago

  • Copied to Backport #19183: jewel: os/filestore/HashIndex: be loud about splits added
Actions #4

Updated by Nathan Cutler about 7 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF