Project

General

Profile

Cleanup #17891

Creation of rbd image with format 1 should be disallowed

Added by Rohith Radhakrishnan over 7 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

We can still create rbd image with format 1 even though it has been deprecated. This should be stopped. eg below:-

rack6-client-1:~/$ sudo rbd -p pool1 create rbd3 --size 409600000 --image-format 1
rbd: image format 1 is deprecated
rack6-client-1:~$ sudo rbd -p pool1 create rbd3 --size 409600000 --image-format 1
rbd: image format 1 is deprecated
rbd: create error: (17) File exists
2016-11-14 15:50:15.941586 7f336c206d80 -1 librbd: rbd image rbd3 already exists

History

#1 Updated by Pavan Rallabhandi over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Pavan Rallabhandi

#2 Updated by Pavan Rallabhandi over 7 years ago

I guess that is expected, refer https://github.com/ceph/ceph/pull/7841/

#3 Updated by Rohith Radhakrishnan over 7 years ago

according to me the statement should be more intuitive. Right now the user will not know if the rbd has been created or not, due to the warning message, as they tend to associate warnings with disruptions.

There is a need to add rbd created successfully message along with the deprecated warning.

#4 Updated by Pavan Rallabhandi over 7 years ago

  • Assignee deleted (Pavan Rallabhandi)

Was looking at this piece recently but would let others comment.

#5 Updated by Jason Dillaman about 7 years ago

  • Tracker changed from Bug to Cleanup
  • Project changed from Ceph to rbd
  • Status changed from In Progress to New
  • Priority changed from Normal to Low

Note: the return code status of the "rbd create" would indicate success or failure. Relying on console output to explicitly state success or failure is non-ideal.

#6 Updated by Gaurav Garg about 7 years ago

@jason does this means that from now onwards we should not even allow creation of image using format 1. means when we create image using format 1 it will give error message "rbd: image format 1 is deprecated" with return value -EINVAL ?

#7 Updated by Gaurav Garg about 7 years ago

  • Assignee set to Gaurav Garg

#8 Updated by Jason Dillaman about 7 years ago

I just sent out an email to the lists to verify that there are no objections to the plan.

#9 Updated by Gaurav Garg about 7 years ago

@jason thank you :), i saw that mail. waiting for suggestion and final decision on this.

#10 Updated by Jos Collin over 6 years ago

  • Status changed from New to In Progress

#11 Updated by Jason Dillaman almost 6 years ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF