https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2016-08-10T19:06:32ZCeph rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=764002016-08-10T19:06:32ZJason Dillamandillaman@redhat.com
<ul><li><strong>Backport</strong> set to <i>jewel</i></li></ul> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=777122016-08-29T13:47:34ZBrett Niverbniver@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>Brett Niver</i></li></ul><p>Seems only one line of code missing - at least to avoid the hang, and allows an error message to be displayed.</p> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=789592016-09-26T11:56:18ZVenky Shankarvshankar@redhat.com
<ul></ul><p>Jason, I think Mykola's PR <a class="external" href="https://github.com/ceph/ceph/pull/10980">https://github.com/ceph/ceph/pull/10980</a> would automatically fix this, right?</p> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=789942016-09-27T08:03:35ZVenky Shankarvshankar@redhat.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Tested with PR#10980, no cli hang was seen:</p>
<blockquote>
<p>./bin/rbd --cluster cluster2 -p mirror feature disable r0 journaling<br />2016-09-27 13:30:57.037843 7fad3f2f4180 -1 WARNING: the following dangerous and experimental features are enabled: *<br />2016-09-27 13:30:57.037890 7fad3f2f4180 -1 WARNING: the following dangerous and experimental features are enabled: *<br />2016-09-27 13:30:57.039812 7fad3f2f4180 -1 WARNING: the following dangerous and experimental features are enabled: *<br />2016-09-27 13:30:57.062617 7fad0f7fe700 -1 librbd::journal::StandardPolicy: local image not promoted<br />2016-09-27 13:30:57.062625 7fad0f7fe700 -1 librbd::exclusive_lock::AcquireRequest: failed to allocate journal tag: (1) Operation not permitted<br />2016-09-27 13:30:57.071543 7fad0f7fe700 -1 librbd::ExclusiveLock: failed to acquire exclusive lock:(1) Operation not permitted<br />rbd: failed to update image features: (30) Read-only file system</p>
</blockquote> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=789952016-09-27T08:04:36ZVenky Shankarvshankar@redhat.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>In Progress</i></li></ul><p>Moved to resolved too quickly, should be done after PR#10980 is merged.</p> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=836852017-01-03T20:19:16ZJason Dillamandillaman@redhat.com
<ul><li><strong>Assignee</strong> changed from <i>Brett Niver</i> to <i>Jason Dillaman</i></li></ul> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=836872017-01-03T20:49:31ZJason Dillamandillaman@redhat.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Fix Under Review</i></li></ul><p><strong>PR</strong>: <a class="external" href="https://github.com/ceph/ceph/pull/12639">https://github.com/ceph/ceph/pull/12639</a> (just the "librbd: fail immediately if the exclusive lock cannot be acquired" portion)</p> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=838812017-01-08T12:25:01ZMykola Golubmgolub@suse.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Pending Backport</i></li></ul> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=838842017-01-08T14:55:28ZJason Dillamandillaman@redhat.com
<ul><li><strong>Backport</strong> changed from <i>jewel</i> to <i>kraken,jewel</i></li></ul> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=838852017-01-08T14:56:17ZJason Dillamandillaman@redhat.com
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li><li><strong>Backport</strong> deleted (<del><i>kraken,jewel</i></del>)</li></ul><p>On second thought: it will be backported by <a class="issue tracker-8 status-3 priority-4 priority-default closed child" title="Subtask: [iscsi]: need an API to break the exclusive lock (Resolved)" href="https://tracker.ceph.com/issues/18327">#18327</a></p> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=880142017-03-27T03:03:55ZJason Dillamandillaman@redhat.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>In Progress</i></li></ul><p>Fix was lost in master branch</p> rbd - Bug #16988: 'rbd feature disable' against non-primary image results in hung CLIhttps://tracker.ceph.com/issues/16988?journal_id=880442017-03-27T16:22:18ZJason Dillamandillaman@redhat.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Verified that it still works in master after exclusive lock / managed lock refactor</p>