Project

General

Profile

Backport #16918

hammer: making stop.sh more portable

Added by Joshua Schmid over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
Release:
hammer

Description

https://github.com/ceph/ceph/pull/10569

for portability/compatibility reasons I'd like to request a backport of this commit to hammer as the script will fail with syntax error when using /bin/bash as default SHELL

echo $SHELL
/bin/bash
./stop.sh

outputs:

./stop.sh: line 73: syntax error near unexpected token `<'
./stop.sh: line 73: ` done < <("${CEPH_BIN}"/rbd showmapped | tail -n +2)'

verify that it works with sh:

sh stop.sh
$?
0

the commit that fixes it:
SHA1: 27f2d806f905df1a51b11bd79f1af4c26471407a

thanks!

History

#1 Updated by Nathan Cutler over 1 year ago

  • Target version deleted (v0.94.8)

#2 Updated by Nathan Cutler over 1 year ago

  • Subject changed from making stop.sh nore portable to hammer: making stop.sh more portable

#3 Updated by Nathan Cutler over 1 year ago

  • Description updated (diff)
  • Status changed from New to In Progress

#4 Updated by Nathan Cutler about 1 year ago

  • Status changed from In Progress to Resolved
  • Target version set to v0.94.10

Also available in: Atom PDF