Backport #16917
closedHammer leaves pg_TEMP directories when PG gets removed
Updated by David Zafman over 7 years ago
- Description updated (diff)
Updated by David Zafman over 7 years ago
- Status changed from In Progress to Fix Under Review
- Assignee set to David Zafman
- Target version set to v0.94.8
Updated by Nathan Cutler over 7 years ago
- Tracker changed from Bug to Backport
- Target version deleted (
v0.94.8) - Release set to hammer
Updated by Nathan Cutler over 7 years ago
- Description updated (diff)
original description¶
This error triggers another bug #16672 on upgrade to later releases.
PGBackend::split_colls() will create a temp collection for the child pg if the parent has temp_created set. However, the child PG in OSD::split_pgs() doesn't get temp_created set, so later if that PG is removed the temp collection is never removed.
We shouldn't include the "destroy parallel temp collection, too" code in FileStore::_destroy_collection() from later releases because in Hammer collections are opaque to the FileStore code.
Updated by Nathan Cutler over 7 years ago
Explanation for my edits: moved to "Backport" tracker because it's a backport; moved description to a comment because we have automation that potentially can clobber the description; removed target version because we don't set that until the PR has been merged.
Updated by David Zafman over 7 years ago
- Status changed from Fix Under Review to Rejected
Decided that this wasn't a necessary backport. Jewel can handle the upgrade with extra pg_TEMP directories, so this change is optional.