Project

General

Profile

Bug #16327

comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign)

Added by Nathan Cutler over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
06/15/2016
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
jewel,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

We are returning -ERR_NOT_MODIFIED but in rgw_rest_s3.cc the conditional omits the minus sign:

$ grep -r ERR_NOT_MODIFIED
src/rgw/rgw_common.h:#define ERR_NOT_MODIFIED         2016
src/rgw/rgw_rest_s3.cc:  if (op_ret == ERR_NOT_MODIFIED) {
src/rgw/rgw_rados.cc:  if (copy_if_newer && ret == -ERR_NOT_MODIFIED) {
src/rgw/rgw_rados.cc:        return -ERR_NOT_MODIFIED;
src/rgw/rgw_rados.cc:        return -ERR_NOT_MODIFIED;
src/rgw/rgw_http_errors.h:    { ERR_NOT_MODIFIED, 304, "NotModified" },
src/rgw/rgw_http_errors.h:      return -ERR_NOT_MODIFIED;

Related issues

Copied to rgw - Backport #16381: jewel: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) Resolved
Copied to rgw - Backport #16382: hammer: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) Resolved

History

#1 Updated by Nathan Cutler over 2 years ago

  • Status changed from New to Need Review

#2 Updated by Nathan Cutler over 2 years ago

  • Related to Backport #15283: hammer: RGW shouldn't send Content-Type nor Content-Length for 304 responses added

#3 Updated by Nathan Cutler over 2 years ago

  • Status changed from Need Review to Resolved

#4 Updated by Nathan Cutler over 2 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to jewel,hammer

#5 Updated by Nathan Cutler over 2 years ago

  • Copied to Backport #16381: jewel: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) added

#6 Updated by Nathan Cutler over 2 years ago

  • Copied to Backport #16382: hammer: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) added

#7 Updated by Nathan Cutler over 2 years ago

  • Related to deleted (Backport #15283: hammer: RGW shouldn't send Content-Type nor Content-Length for 304 responses)

#8 Updated by Loic Dachary over 2 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF