Actions
Bug #15991
closedShould not allow the allow-shrink flag while resizing the image to a greater size
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
--Allow-shrink flag right now can be be used even while increasing the rbd image size. We should restrict the flag to be used only for reducing the size, as otherwise user will use it by default and could lead to incorrect size reduction problems.
Updated by Jason Dillaman almost 8 years ago
- Status changed from New to In Progress
Updated by Brett Niver almost 8 years ago
- Status changed from In Progress to Fix Under Review
Pull request available :
rbd: don't allow --allow-shrink when growing image #9408
Updated by Ilya Dryomov almost 8 years ago
- Status changed from Fix Under Review to Rejected
See discussion in https://github.com/ceph/ceph/pull/9408.
Updated by Rohith Radhakrishnan almost 8 years ago
If this is used as a force flag wouldn't it be better to have one common force flag for growing and reducing the size, rather than have a separate flag for reducing the size.
I still think reducing/growing size are two different operations and therefore there should be two separate commands to handle the same and not one single command.
Actions