Project

General

Profile

Bug #15574

Parent image is closed twice if error encountered while opening

Added by Jason Dillaman about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Target version:
-
Start date:
04/22/2016
Due date:
% Done:

0%

Source:
Q/A
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

The `OpenRequest` state machine will properly close the image upon error. However, the `RefreshParentRequest` will also attempt to close the (already closed) parent image if it encountered an error when opening the image. This will result in an assertion failure due to the double shut down.

#0  0x00007f12287fffcb in raise () from /lib64/libpthread.so.0
#1  0x00007f123c403eb5 in reraise_fatal (signum=6) at global/signal_handler.cc:71
#2  handle_fatal_signal (signum=6) at global/signal_handler.cc:133
#3  <signal handler called>
#4  0x00007f122684d5f7 in raise () from /lib64/libc.so.6
#5  0x00007f122684ece8 in abort () from /lib64/libc.so.6
#6  0x00007f123295e057 in ceph::__ceph_assert_fail (assertion=<optimized out>, file=<optimized out>, line=212, 
    func=0x7f1232c14ee0 <librbd::AioImageRequestWQ::shut_down(Context*)::__PRETTY_FUNCTION__> "void librbd::AioImageRequestWQ::shut_down(Context*)") at common/assert.cc:78
#7  0x00007f1232764bf4 in librbd::AioImageRequestWQ::shut_down (this=0x7f11fc002450, on_shutdown=0x7f11fc0039e0) at librbd/AioImageRequestWQ.cc:212

Related issues

Copied to rbd - Backport #15661: jewel: Parent image is closed twice if error encountered while opening Resolved

History

#1 Updated by Jason Dillaman about 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman

#2 Updated by Jason Dillaman about 3 years ago

  • Status changed from In Progress to Need Review

#3 Updated by Jason Dillaman about 3 years ago

  • Status changed from Need Review to Pending Backport

#4 Updated by Nathan Cutler about 3 years ago

  • Copied to Backport #15661: jewel: Parent image is closed twice if error encountered while opening added

#5 Updated by Jason Dillaman about 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF