Actions
Bug #15042
closedbtrfs buildrequire added to fix make check does not get installed by install-deps.sh
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
https://github.com/ceph/ceph/pull/7742 fixed a make check failure by adding a buildtime dependency:
%if %{with tests}
BuildRequires: btrfsprogs
%endif
However, on RH/Fedora this gets ignored by install-deps.sh because yum-builddeps has no option to define %{with_tests} - the conditional does not trigger.
Since the interest of having all make check dependencies satisfied trumps the interest of keeping build environments small, the fix in this case is to drop the conditional.
Updated by Nathan Cutler about 8 years ago
- Status changed from New to Fix Under Review
master PR: https://github.com/ceph/ceph/pull/8016
Deeper analysis in the commit message there.
Updated by Sage Weil about 8 years ago
- Status changed from Fix Under Review to Resolved
Actions