Project

General

Profile

Bug #14844

rpm package building fails if the build machine has lttng and babeltrace development packages installed locally

Added by runsisi hust almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
Start date:
02/23/2016
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
hammer, infernalis
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

OS:

LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description:    CentOS Linux release 7.2.1511 (Core) 
Release:        7.2.1511
Codename:       Core

with lttng and babeltrace development packages installed:
[runsisi@hust ~]$ rpm -qa | grep lttng
lttng-ust-2.7.1-1.el7.x86_64
lttng-ust-devel-2.7.1-1.el7.x86_64
[runsisi@hust ~]$ rpm -qa | grep babeltrace
babeltrace-devel-1.3.1-1.el7.x86_64
babeltrace-1.3.1-1.el7.x86_64

when building the latest rpm package for ceph, i.e. 10.0.2 from tarball or the latest git version, following errors occurrs:
error: Installed (but unpackaged) file(s) found:
   /usr/bin/rbd-replay-prep
   /usr/lib64/libos_tp.so
   /usr/lib64/libos_tp.so.1
   /usr/lib64/libos_tp.so.1.0.0
   /usr/lib64/libosd_tp.so
   /usr/lib64/libosd_tp.so.1
   /usr/lib64/libosd_tp.so.1.0.0
   /usr/lib64/librados_tp.so
   /usr/lib64/librados_tp.so.2
   /usr/lib64/librados_tp.so.2.0.0
   /usr/lib64/librbd_tp.so
   /usr/lib64/librbd_tp.so.1
   /usr/lib64/librbd_tp.so.1.0.0

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/bin/rbd-replay-prep
   /usr/lib64/libos_tp.so
   /usr/lib64/libos_tp.so.1
   /usr/lib64/libos_tp.so.1.0.0
   /usr/lib64/libosd_tp.so
   /usr/lib64/libosd_tp.so.1
   /usr/lib64/libosd_tp.so.1.0.0
   /usr/lib64/librados_tp.so
   /usr/lib64/librados_tp.so.2
   /usr/lib64/librados_tp.so.2.0.0
   /usr/lib64/librbd_tp.so
   /usr/lib64/librbd_tp.so.1
   /usr/lib64/librbd_tp.so.1.0.0

the ceph.spec.in only enables lttng/babeltrace for RHEL/CentOS 6:

%if 0%{?fedora} || 0%{?rhel} == 6 || 0%{?suse_version} == 1315
%global _with_lttng 1
%endif

while the configure.ac auto enables lttng/babeltrace if it detects:
AS_IF([test "x$with_lttng" = "xno"], [use_lttng=no],
      [test "x$with_lttng" = "xyes"], [use_lttng=yes],
      [test "x$have_good_lttng_gen_tp" = "xyes"], [use_lttng=yes; AC_MSG_NOTICE([lttng auto-enabled])],
      [use_lttng=no; AC_MSG_NOTICE([lttng auto-disabled])])
AM_CONDITIONAL([WITH_LTTNG], test x"$use_lttng" = x"yes")

and
AS_IF([test "x$with_babeltrace" = "xno"], [use_babeltrace=no],
      [test "x$with_babeltrace" = "xyes"], [use_babeltrace=yes],
      [test "x$ac_cv_header_babeltrace_ctf_events_h$ac_cv_header_babeltrace_babeltrace_h$have_good_babeltrace" = "xyesyesyes"], [use_babeltrace=yes; AC_MSG_NOTICE([babeltrace auto-enabled])],
      [use_babeltrace=no; AC_MSG_NOTICE([babeltrace auto-disabled])])
AM_CONDITIONAL([WITH_BABELTRACE], test x"$use_babeltrace" = x"yes")

so, we should either disable the auto enabled lttng/babeltrace detection or build with-lttng on RHEL/CentOS 7


Related issues

Copied to Ceph - Backport #15382: hammer: rpm package building fails if the build machine has lttng and babeltrace development packages installed locally Resolved
Copied to Ceph - Backport #15498: infernalis: rpm package building fails if the build machine has lttng and babeltrace development packages installed locally Resolved

Associated revisions

Revision f1a44907 (diff)
Added by Kefu Chai almost 3 years ago

ceph.spec.in: disable lttng and babeltrace explicitly

before this change, we do not pacakge tracepoint probe shared libraries
on rhel7. but "configure" script enables them if lttng is detected. and
rpm complains at seeing installed but not pacakged files. as EPEL-7 now
includes lttng-ust-devel and libbabeltrace-devel, we'd better
BuildRequire them, and build with them unless disabled otherwise. so in
this change
  • make "lttng" an rpm build option enabled by default
  • BuildRequire lttng-ust-devel and libbabeltrace-devel if the "lttng"
    "lttng" option is enabled
  • --without-lttng --without-babeltrace if the "lttng" option is disabled

Fixes: #14844
Signed-off-by: Kefu Chai <>

Revision 77a4ed0a (diff)
Added by Loic Dachary almost 3 years ago

ceph.spec.in: disable lttng and babeltrace explicitly

before this change, we do not pacakge tracepoint probe shared libraries
on rhel7. but "configure" script enables them if lttng is detected. and
rpm complains at seeing installed but not pacakged files. as EPEL-7 now
includes lttng-ust-devel and libbabeltrace-devel, we'd better
BuildRequire them, and build with them unless disabled otherwise. so in
this change
  • make "lttng" an rpm build option enabled by default
  • BuildRequire lttng-ust-devel and libbabeltrace-devel if the "lttng"
    "lttng" option is enabled
  • --without-lttng --without-babeltrace if the "lttng" option is disabled

Fixes: #14844
Signed-off-by: Kefu Chai <>
(cherry picked from commit f1a44907a2f83cb8080cd8ab5980a30306a33fbd)

Conflicts:
ceph.spec.in: trivial resolution, the context changed
(other packages, files etc.) but the semantic did not

Revision b338815e (diff)
Added by Kefu Chai almost 3 years ago

ceph.spec.in: disable lttng and babeltrace explicitly

before this change, we do not pacakge tracepoint probe shared libraries
on rhel7. but "configure" script enables them if lttng is detected. and
rpm complains at seeing installed but not pacakged files. as EPEL-7 now
includes lttng-ust-devel and libbabeltrace-devel, we'd better
BuildRequire them, and build with them unless disabled otherwise. so in
this change
  • make "lttng" an rpm build option enabled by default
  • BuildRequire lttng-ust-devel and libbabeltrace-devel if the "lttng"
    "lttng" option is enabled
  • --without-lttng --without-babeltrace if the "lttng" option is disabled

Fixes: #14844
Signed-off-by: Kefu Chai <>
(cherry picked from commit f1a44907a2f83cb8080cd8ab5980a30306a33fbd)

Conflicts:
ceph.spec.in

History

#1 Updated by xie xingguo almost 3 years ago

  • Assignee set to Kefu Chai

@Kefu Chai
Would you mind having a look at this?

#2 Updated by Kefu Chai almost 3 years ago

  • Status changed from New to Need Review
  • Priority changed from Normal to Low

#3 Updated by Ken Dreyer almost 3 years ago

I'd really like to get lttng and babeltrace into EPEL 7. This bug prompted me to go ahead and do builds for that.

babeltrace: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8c74b0b27f
lttng-ust: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-200bd827c6

It's going to take a couple weeks for the packages to go through the epel-testing process in bodhi.fedoraproject.org. You can make it go faster by installing the packages now and logging into Bodhi and providing karma. When the updates hit the stable karma threshold (3 positive), then they will go to the EPEL 7 stable repository.

#4 Updated by Kefu Chai almost 3 years ago

Ken, thanks for your work! the packages install just fine in my centos7 box. 1 more karma needed for them.

#5 Updated by Kefu Chai almost 3 years ago

  • Status changed from Need Review to Resolved

#6 Updated by Loic Dachary almost 3 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to hammer

#7 Updated by Loic Dachary almost 3 years ago

  • Copied to Backport #15382: hammer: rpm package building fails if the build machine has lttng and babeltrace development packages installed locally added

#8 Updated by Samuel Just almost 3 years ago

  • Priority changed from Low to Urgent
  • Backport changed from hammer to hammer, infernalis

Messing up infernalis build?

#9 Updated by Nathan Cutler almost 3 years ago

  • Copied to Backport #15498: infernalis: rpm package building fails if the build machine has lttng and babeltrace development packages installed locally added

#10 Updated by Dan Mick almost 3 years ago

I pushed a fix to infernalis
https://github.com/ceph/ceph/pull/8589
8224952b3fcd496f531194b8570d2f2c849bb04b

#11 Updated by Nathan Cutler almost 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF