Fix rbd run cli test
run cli test will always pass due to exit 0, need to check if the scirpt is outdated and needs a newer or better version
#2 Updated by Nathan Cutler over 2 years ago
There is a suite yaml facet: https://github.com/ceph/ceph/blob/master/qa/suites/rbd/basic/tasks/rbd_cli_tests.yaml
which runs a workunit: https://github.com/ceph/ceph/blob/master/qa/workunits/rbd/run_cli_tests.sh
which downloads a Perl script http://download.ceph.com/qa/rbd_cli_tests.pls [ why .pls ?? ]
which is identical to https://github.com/ceph/ceph/blob/master/qa/qa_scripts/rbd_cli_tests.pl
The workunit also downloads http://download.ceph.com/qa/RbdLib.pm
which is almost exactly the same as https://github.com/ceph/ceph/blob/master/qa/qa_scripts/RbdLib.pm
smithfarm@wilbur:~/src/ceph/SUSE/ceph> diff ~/Downloads/RbdLib.pm qa/qa_scripts/RbdLib.pm 84,85c84 < our $SNAP_UNPROT_ERR1 = "snap_unprotect: can't unprotect"; < #our $SNAP_UNPROTECT_ERR - bug # 4045 --- > our $SNAP_UNPROT_ERR1 = "snap_unprotect: snapshot is already unprotected";
(https://github.com/ceph/ceph/pull/1027 explains that change)
qa/ lives in ceph/ceph.git and teuthology clones that repo, the workunit would not have to download anything - it could do something like this:
#!/bin/bash ( cd $(dirname $0)/../../../qa/qa_scripts ; perl rbd_cli_tests.pls --pool test )
( This was inspired by https://github.com/ceph/ceph/commit/cf294777ea92f0911813a7132068584d4f73a65a )
#5 Updated by Nathan Cutler over 2 years ago
A run to see how the rbd_cli_tests.yaml behaves in master (wip-18440 and master are equivalent as far as this run is concerned):
teuthology-suite --priority 101 --suite rbd --email email@example.com --ceph wip-18440 --machine-type smithi --kernel distro --filter="basic/tasks/rbd_cli_tests.yaml"
The output from run_cli_tests.sh shows that many of the test cases fail:
========================================================================================== TEST RESULTS ========================================================================================== ========================================================================================== No. of test cases passed:45 No. of test cases failed:30 ==========================================================================================
The numbers of test cases passed and failed vary from test to test.
Since the underlying Perl script always exits with status 0, the CLI test failures do not cause teuthology to report a test failure.