Project

General

Profile

Bug #14815

os/filestore: mount may return OK even if it encounters internal error.

Added by xie xingguo over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
02/19/2016
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

This bug is much alike as
http://tracker.ceph.com/issues/14814

But I make a new one in case they need to be treated separately,
such as one needs to be backported and the other does not, and vice versa.

Associated revisions

Revision 7be19c28 (diff)
Added by xie xingguo over 3 years ago

os/filestore: fix wrong scope of result code for error cases during mount

This pr is similar to https://github.com/ceph/ceph/pull/7704
but I feel like making a new one in case they need to be treated separately,
such as one needs to be backported while the other does not, and vice versa.

During the mount process, if we fail to read op_seq or create a no-snap-fn,
the mount process is abnormally terminated but we may
still return a positive answer to the caller, which is misleading.

This patch is provided to solve the above problems by correctly setting
'ret' correspondingly under these cases, which is the final answer to
be passed out for caller.

Fixes: #14815
Signed-off-by: xie xingguo <>

History

#1 Updated by xie xingguo over 3 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF