Project

General

Profile

Bug #14747

test_bit_vector.cc uses magic numbers against #defines that vary

Added by Dan Mick over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
librbd
Target version:
-
Start date:
02/12/2016
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
hammer, infernalis
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

test_bit_vector's partial_decode_encode test allocates a 9161-element bit vector, and then tests with ranges based on 2 * CEPH_PAGE_SIZE, which works when CEPH_PAGE_SIZE is 4096, which it is on x86 (it's the system page size); however, on aarch64, the system page size is 64K, so the test fails.


Related issues

Copied to Ceph - Bug #14771: test_bit_vector.cc uses magic numbers against #defines that vary Rejected 02/12/2016
Copied to Ceph - Backport #14782: infernalis: test_bit_vector.cc uses magic numbers against #defines that vary Rejected
Copied to Ceph - Backport #14783: hammer: test_bit_vector.cc uses magic numbers against #defines that vary Resolved

Associated revisions

Revision ba2e6ce4 (diff)
Added by Jason Dillaman over 3 years ago

common/bit_vector: use hard-coded value for block size

The CEPH_PAGE_SIZE is not actually a constant. On aarch64 platforms
the page size is 64K instead of the assumed 4K. The CRC block
computations require a true constant.

Fixes: #14747
Signed-off-by: Jason Dillaman <>

Revision 31a2fc47 (diff)
Added by Jason Dillaman over 3 years ago

common/bit_vector: use hard-coded value for block size

The CEPH_PAGE_SIZE is not actually a constant. On aarch64 platforms
the page size is 64K instead of the assumed 4K. The CRC block
computations require a true constant.

Fixes: #14747
Signed-off-by: Jason Dillaman <>
(cherry picked from commit ba2e6ce46fb5f781ffaf6483db8ebd99238419c6)

History

#1 Updated by Jason Dillaman over 3 years ago

  • Status changed from Verified to Need Review

#2 Updated by Dan Mick over 3 years ago

  • Copied to Bug #14771: test_bit_vector.cc uses magic numbers against #defines that vary added

#3 Updated by Dan Mick over 3 years ago

  • Status changed from Need Review to Resolved

#4 Updated by Dan Mick over 3 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to hammer, infernalis

#5 Updated by Loic Dachary over 3 years ago

  • Copied to Backport #14782: infernalis: test_bit_vector.cc uses magic numbers against #defines that vary added

#6 Updated by Loic Dachary over 3 years ago

  • Copied to Backport #14783: hammer: test_bit_vector.cc uses magic numbers against #defines that vary added

#7 Updated by Loic Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF