Project

General

Profile

Bug #14187

fs: fix return code of mkfs

Added by xie xingguo about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
12/27/2015
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

int FileStore::mkfs()
if (::fsync(fsid_fd) < 0) {
ret = errno;
derr << "mkfs: close failed: can't write fsid: "
<< cpp_strerror(ret) << dendl;
goto close_fsid_fd;
}

Shall return a negative error code instead.

Associated revisions

Revision 31205cea (diff)
Added by xie xingguo about 3 years ago

os: fix return code if unable to sync

Shall return a negative error code instead.

Fixes: #14187
Signed-off-by: xie xingguo <>

History

#1 Updated by Sage Weil about 3 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF