Project

General

Profile

Bug #14151

ReplicatedPG: wrong result code checking logic during sparse_read

Added by xie xingguo over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
-
Target version:
-
Start date:
12/22/2015
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
infernalis,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

See ReplicatedPG::do_osd_ops:
// verify trailing hole?
if (cct->_conf->osd_verify_sparse_read_holes)

Shall check result code of non-hole reading before verifying trailing hole.


Related issues

Copied to Ceph - Backport #14286: infernalis: ReplicatedPG: wrong result code checking logic during sparse_read Rejected
Copied to Ceph - Backport #14287: hammer: ReplicatedPG: wrong result code checking logic during sparse_read Resolved

Associated revisions

Revision b3aa29e3 (diff)
Added by xie xingguo over 3 years ago

ReplicatedPG: fix sparse-read result code checking logic

Move ahead the result code checking logic before we continue to verify the trailing hole, otherwise
the real result of non-hole reading may be overwritten and thus confuse caller.

Fixes: #14151
Signed-off-by: xie xingguo <>

Revision 1ab2b481 (diff)
Added by xie xingguo over 3 years ago

ReplicatedPG: fix sparse-read result code checking logic

Move ahead the result code checking logic before we continue to verify the trailing hole, otherwise
the real result of non-hole reading may be overwritten and thus confuse caller.

Fixes: #14151
Signed-off-by: xie xingguo <>
(cherry picked from commit b3aa29e324cf0a96a1f2f5dcf1ba998219457bcd)

Conflicts:
src/osd/ReplicatedPG.cc: trivial resolution

History

#1 Updated by Sage Weil over 3 years ago

  • Status changed from New to Pending Backport
  • Backport set to infernalis,hammer

#2 Updated by Loic Dachary over 3 years ago

  • Copied to Backport #14286: infernalis: ReplicatedPG: wrong result code checking logic during sparse_read added

#3 Updated by Loic Dachary over 3 years ago

  • Copied to Backport #14287: hammer: ReplicatedPG: wrong result code checking logic during sparse_read added

#5 Updated by Loic Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF