Project

General

Profile

Bug #14129

librbd: snap_exists API overflow!

Added by xie xingguo over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Target version:
-
Start date:
12/19/2015
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

See Internal.cc

bool snap_exists(ImageCtx *ictx, const char *snap_name) {
ldout(ictx->cct, 20) << "snap_exists " << ictx << " " << snap_name << dendl;

int r = ictx->state->refresh_if_required();
if (r < 0)
return r;// overflowed.

Associated revisions

Revision c97b1a68 (diff)
Added by xie xingguo over 3 years ago

librbd: fix snap_exists API overflow issue

The original one may overflow and thus not be safe.

Fixes: #14129
Signed-off-by: xie xingguo <>

History

#2 Updated by Nathan Cutler over 3 years ago

  • Project changed from Ceph to rbd

#3 Updated by Nathan Cutler over 3 years ago

  • Status changed from New to Need Review

#4 Updated by xie xingguo over 3 years ago

xie xingguo wrote:

https://github.com/ceph/ceph/pull/6986

@Nathan Cutler
Resolved.

#5 Updated by Nathan Cutler over 3 years ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF