Project

General

Profile

Bug #13719

perf dump for librbd socket generates invalid xml due to slash in attribute name

Added by Mykola Golub over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
11/07/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

% ceph --format xml --admin-daemon out/client.admin.19285.asok perf dump > /tmp/perf.xml
% xmllint /tmp/perf.xml
/tmp/perf.xml:1: parser error : error parsing attribute name
<perfcounter_collection><librbd--rbd/testimg26926><rd>0</rd><rd_bytes>0</rd_byte
^
/tmp/perf.xml:1: parser error : attributes construct error

Associated revisions

Revision fbe5526d (diff)
Added by Mykola Golub over 3 years ago

librbd: perf section name: use hyphen to separate components

"/" and "@" characters make invalid xml format output.

Fixes: #13719
Signed-off-by: Mykola Golub <>

History

#1 Updated by Mykola Golub over 3 years ago

The easiest fix (workaround) could be not to use "/" as a separator between pool and image name.

#2 Updated by Jason Dillaman over 3 years ago

It won't support the "@" character for a snapshot name, either. I am fine w/ just using a hyphen to separate the components.

#4 Updated by Jason Dillaman over 3 years ago

  • Status changed from New to Need Review

#5 Updated by Jason Dillaman over 3 years ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF