Project

General

Profile

Bug #13674

Avoid re-writing old-format image header on resize

Added by Jason Dillaman about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Target version:
-
Start date:
11/02/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
infernalis,hammer,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

Race conditions are possible between snapshot creation and resize operations (especially if there are issues with watch/notify preventing a header re-read). For example, if a stale snapshot sequence is written to the header, the image will no longer be able to be opened:

librbd: image snap context is invalid!(5) Input/output error

Related issues

Copied to rbd - Backport #13752: Avoid re-writing old-format image header on resize Rejected
Copied to rbd - Backport #13753: Avoid re-writing old-format image header on resize Resolved
Copied to rbd - Backport #13754: Avoid re-writing old-format image header on resize Resolved

Associated revisions

Revision d5be20b6 (diff)
Added by Jason Dillaman about 3 years ago

librbd: resize should only update image size within header

Previously, the whole RBD image format 1 header struct was
re-written to disk on a resize operation.

Fixes: #13674
Backport: infernalis, hammer, firefly
Signed-off-by: Jason Dillaman <>

Revision a3223173 (diff)
Added by Jason Dillaman about 3 years ago

librbd: resize should only update image size within header

Previously, the whole RBD image format 1 header struct was
re-written to disk on a resize operation.

Fixes: #13674
Backport: infernalis, hammer, firefly
Signed-off-by: Jason Dillaman <>
(cherry picked from commit d5be20b6d4646284571568ab28cbf45b0729390b)

Revision 74cb593a (diff)
Added by Jason Dillaman about 3 years ago

librbd: resize should only update image size within header

Previously, the whole RBD image format 1 header struct was
re-written to disk on a resize operation.

Fixes: #13674
Backport: infernalis, hammer, firefly
Signed-off-by: Jason Dillaman <>
(cherry picked from commit d5be20b6d4646284571568ab28cbf45b0729390b)

History

#1 Updated by Jason Dillaman about 3 years ago

  • Backport set to infernalis,hammer,firefly

#2 Updated by Jason Dillaman about 3 years ago

  • Status changed from In Progress to Need Review

#3 Updated by Loic Dachary about 3 years ago

  • Copied to Backport #13752: Avoid re-writing old-format image header on resize added

#4 Updated by Loic Dachary about 3 years ago

  • Copied to Backport #13753: Avoid re-writing old-format image header on resize added

#5 Updated by Loic Dachary about 3 years ago

  • Copied to Backport #13754: Avoid re-writing old-format image header on resize added

#6 Updated by Loic Dachary about 3 years ago

  • Status changed from Need Review to Pending Backport

#7 Updated by Loic Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF