Project

General

Profile

Feature #13633

Verify self-managed snapshot functionality on image create

Added by Jason Dillaman over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Target version:
-
Start date:
10/28/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
hammer,infernalis
Reviewed:
Affected Versions:
Pull request ID:

Description

If a user accidentally creates a pool snapshot on an RBD pool, images can no longer be snapshotted. There is no way to recover w/o recreating the pool. Update the docs to warn of this behavior and optionally add a test to allocate/release a self-managed snapshot when this is the first image in a pool. Allow this check to be bypassed via a config setting.


Related issues

Copied to rbd - Backport #14142: infernalis: Verify self-managed snapshot functionality on image create Resolved
Copied to rbd - Backport #14143: hammer: Verify self-managed snapshot functionality on image create Resolved

Associated revisions

Revision 1fea4dad (diff)
Added by Jason Dillaman over 3 years ago

librbd: optionally validate RBD pool configuration (snapshot support)

Fixes: #13633
Signed-off-by: Jason Dillaman <>

Revision 96cb5e28 (diff)
Added by Jason Dillaman over 3 years ago

librbd: optionally validate RBD pool configuration (snapshot support)

Fixes: #13633
Signed-off-by: Jason Dillaman <>
(cherry picked from commit 1fea4dadc60e13518e9ee55d136fbc4e9d3a621e)

Revision 8c28f2f2 (diff)
Added by Jason Dillaman over 3 years ago

librbd: optionally validate RBD pool configuration (snapshot support)

Fixes: #13633
Signed-off-by: Jason Dillaman <>
(cherry picked from commit 1fea4dadc60e13518e9ee55d136fbc4e9d3a621e)

Conflicts:
src/common/config_opts.h: trivial resolution

History

#1 Updated by Jason Dillaman over 3 years ago

User will see something like the following error if the pool is not in self-managed snapshot mode:

# rbd snap create test-vol@test-vol-snap 
librbd: failed to create snap id: (22) Invalid argument

#2 Updated by Jason Dillaman over 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman

#3 Updated by Jason Dillaman over 3 years ago

  • Backport set to hammer,infernalis

#4 Updated by Jason Dillaman over 3 years ago

  • Status changed from In Progress to Need Review

#5 Updated by Jason Dillaman over 3 years ago

  • Status changed from Need Review to Pending Backport

#6 Updated by Abhishek Varshney over 3 years ago

  • Copied to Backport #14142: infernalis: Verify self-managed snapshot functionality on image create added

#7 Updated by Abhishek Varshney over 3 years ago

  • Copied to Backport #14143: hammer: Verify self-managed snapshot functionality on image create added

#8 Updated by Loic Dachary over 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF